[PR #2383] [MERGED] shader_recompiler: Exclude defaulted fragment inputs from quad/rect passthrough. #2690

New issue

Closed

opened 2026-02-27 22:00:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2383
Author: @squidbus
Created: 2/9/2025
Status: ✅ Merged
Merged: 2/11/2025
Merged by: @squidbus

Base: main ← Head: fix-tcs

📝 Commits (1)

b4a9e2a shader_recompiler: Exclude defaulted fragment inputs from quad/rect passthrough.

📊 Changes

3 files changed (+15 additions, -3 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/emit_spirv_quad_rect.cpp (+10 -2)
📝 src/shader_recompiler/backend/spirv/spirv_emit_context.cpp (+1 -1)
📝 src/shader_recompiler/runtime_info.h (+4 -0)

📄 Description

Defaulted parameters are not declared as inputs to the fragment shader. In the quad list / rect list tessellation shaders, fix some validation errors around missing shader inputs from vertex stage by using the same condition on the passthrough declarations as used for declaring the inputs in fragment shaders.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2383 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 2/9/2025 **Status:** ✅ Merged **Merged:** 2/11/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `fix-tcs` --- ### 📝 Commits (1) - [`b4a9e2a`](https://github.com/shadps4-emu/shadPS4/commit/b4a9e2ab1206e04a833450e024761d69b4be4494) shader_recompiler: Exclude defaulted fragment inputs from quad/rect passthrough. ### 📊 Changes **3 files changed** (+15 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/emit_spirv_quad_rect.cpp` (+10 -2) 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.cpp` (+1 -1) 📝 `src/shader_recompiler/runtime_info.h` (+4 -0) </details> ### 📄 Description Defaulted parameters are not declared as inputs to the fragment shader. In the quad list / rect list tessellation shaders, fix some validation errors around missing shader inputs from vertex stage by using the same condition on the passthrough declarations as used for declaring the inputs in fragment shaders. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>