mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-25 07:46:01 +03:00
[PR #2334] [MERGED] Change Background Image for games #2657
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#2657
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/shadps4-emu/shadPS4/pull/2334
Author: @pablodrake
Created: 2/2/2025
Status: ✅ Merged
Merged: 2/4/2025
Merged by: @squidbus
Base:
main← Head:fix-issue-2258📝 Commits (10+)
4040f58Added opacity change instead of blur for background imagebd4cd96Fixed integer overflow when refreshing grid list681c1bbAdded slider to control background image opacityfaebea5Added show background image buttonbe979a5Added UI code for checkbox and English and Spanish translations for new UI elements224aeceRemoved background image caching91ff7e7Background image update on apply/save88f3e06Only recompute image if opacity or game changesf340ae4Fixed segfault when trying to change opacity after table refresh6852b06Placed background image settings under GUI in settings file📊 Changes
13 files changed (+275 additions, -52 deletions)
View changed files
📝
src/common/config.cpp(+24 -0)📝
src/common/config.h(+4 -0)📝
src/qt_gui/game_grid_frame.cpp(+52 -28)📝
src/qt_gui/game_grid_frame.h(+2 -0)📝
src/qt_gui/game_list_frame.cpp(+32 -23)📝
src/qt_gui/game_list_frame.h(+4 -1)📝
src/qt_gui/game_list_utils.h(+26 -0)📝
src/qt_gui/main_window.cpp(+17 -0)📝
src/qt_gui/settings_dialog.cpp(+11 -0)📝
src/qt_gui/settings_dialog.h(+1 -0)📝
src/qt_gui/settings_dialog.ui(+70 -0)📝
src/qt_gui/translations/en.ts(+16 -0)📝
src/qt_gui/translations/es_ES.ts(+16 -0)📄 Description
This pr aims to fix this issue, by changing the way the background image for games is computed and also adding a checkbox to be able to hide the background image and a slider to change the opacity of the displayed image.
Also while using grid view I came across a bug that would cause the emulator to crash if a cell was selected and the refresh button was pressed, this caused an integer overflow on onCurrentCellChanged, this was easily fixed by some bounds checking.
List view example:

Grid view example:

Added base English translations for the new UI elements and Spanish translations aswell.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.