[PR #2334] [MERGED] Change Background Image for games #2657

Closed
opened 2026-02-27 22:00:45 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2334
Author: @pablodrake
Created: 2/2/2025
Status: Merged
Merged: 2/4/2025
Merged by: @squidbus

Base: mainHead: fix-issue-2258


📝 Commits (10+)

  • 4040f58 Added opacity change instead of blur for background image
  • bd4cd96 Fixed integer overflow when refreshing grid list
  • 681c1bb Added slider to control background image opacity
  • faebea5 Added show background image button
  • be979a5 Added UI code for checkbox and English and Spanish translations for new UI elements
  • 224aece Removed background image caching
  • 91ff7e7 Background image update on apply/save
  • 88f3e06 Only recompute image if opacity or game changes
  • f340ae4 Fixed segfault when trying to change opacity after table refresh
  • 6852b06 Placed background image settings under GUI in settings file

📊 Changes

13 files changed (+275 additions, -52 deletions)

View changed files

📝 src/common/config.cpp (+24 -0)
📝 src/common/config.h (+4 -0)
📝 src/qt_gui/game_grid_frame.cpp (+52 -28)
📝 src/qt_gui/game_grid_frame.h (+2 -0)
📝 src/qt_gui/game_list_frame.cpp (+32 -23)
📝 src/qt_gui/game_list_frame.h (+4 -1)
📝 src/qt_gui/game_list_utils.h (+26 -0)
📝 src/qt_gui/main_window.cpp (+17 -0)
📝 src/qt_gui/settings_dialog.cpp (+11 -0)
📝 src/qt_gui/settings_dialog.h (+1 -0)
📝 src/qt_gui/settings_dialog.ui (+70 -0)
📝 src/qt_gui/translations/en.ts (+16 -0)
📝 src/qt_gui/translations/es_ES.ts (+16 -0)

📄 Description

This pr aims to fix this issue, by changing the way the background image for games is computed and also adding a checkbox to be able to hide the background image and a slider to change the opacity of the displayed image.

Also while using grid view I came across a bug that would cause the emulator to crash if a cell was selected and the refresh button was pressed, this caused an integer overflow on onCurrentCellChanged, this was easily fixed by some bounds checking.

List view example:
output

Grid view example:
output1

Added base English translations for the new UI elements and Spanish translations aswell.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2334 **Author:** [@pablodrake](https://github.com/pablodrake) **Created:** 2/2/2025 **Status:** ✅ Merged **Merged:** 2/4/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `fix-issue-2258` --- ### 📝 Commits (10+) - [`4040f58`](https://github.com/shadps4-emu/shadPS4/commit/4040f58af6d2d8ce8c25b19e47602d1ca1853796) Added opacity change instead of blur for background image - [`bd4cd96`](https://github.com/shadps4-emu/shadPS4/commit/bd4cd9632c70e0e0951e8925798b7236555cb199) Fixed integer overflow when refreshing grid list - [`681c1bb`](https://github.com/shadps4-emu/shadPS4/commit/681c1bbf649621710f17d905c6ebcf97d9d0edb9) Added slider to control background image opacity - [`faebea5`](https://github.com/shadps4-emu/shadPS4/commit/faebea56ebff4366eefef2bc584da65bf282076f) Added show background image button - [`be979a5`](https://github.com/shadps4-emu/shadPS4/commit/be979a535d969280ce3447c0c5583c88a7e48012) Added UI code for checkbox and English and Spanish translations for new UI elements - [`224aece`](https://github.com/shadps4-emu/shadPS4/commit/224aece0296b404e6e3108e981afe1f7c1874419) Removed background image caching - [`91ff7e7`](https://github.com/shadps4-emu/shadPS4/commit/91ff7e743ce98c49d02682f0849620ba71213f1b) Background image update on apply/save - [`88f3e06`](https://github.com/shadps4-emu/shadPS4/commit/88f3e06bd663e702e8bc89ce93c85597daf04b30) Only recompute image if opacity or game changes - [`f340ae4`](https://github.com/shadps4-emu/shadPS4/commit/f340ae471d106bc525f38a6cab4bfa7dde60f177) Fixed segfault when trying to change opacity after table refresh - [`6852b06`](https://github.com/shadps4-emu/shadPS4/commit/6852b06528093adece44a3489e07754a8f059131) Placed background image settings under GUI in settings file ### 📊 Changes **13 files changed** (+275 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `src/common/config.cpp` (+24 -0) 📝 `src/common/config.h` (+4 -0) 📝 `src/qt_gui/game_grid_frame.cpp` (+52 -28) 📝 `src/qt_gui/game_grid_frame.h` (+2 -0) 📝 `src/qt_gui/game_list_frame.cpp` (+32 -23) 📝 `src/qt_gui/game_list_frame.h` (+4 -1) 📝 `src/qt_gui/game_list_utils.h` (+26 -0) 📝 `src/qt_gui/main_window.cpp` (+17 -0) 📝 `src/qt_gui/settings_dialog.cpp` (+11 -0) 📝 `src/qt_gui/settings_dialog.h` (+1 -0) 📝 `src/qt_gui/settings_dialog.ui` (+70 -0) 📝 `src/qt_gui/translations/en.ts` (+16 -0) 📝 `src/qt_gui/translations/es_ES.ts` (+16 -0) </details> ### 📄 Description This pr aims to fix [this](https://github.com/shadps4-emu/shadPS4/issues/2258) issue, by changing the way the background image for games is computed and also adding a checkbox to be able to hide the background image and a slider to change the opacity of the displayed image. Also while using grid view I came across a bug that would cause the emulator to crash if a cell was selected and the refresh button was pressed, this caused an integer overflow on onCurrentCellChanged, this was easily fixed by some bounds checking. List view example: ![output](https://github.com/user-attachments/assets/b4d022d2-96e3-43d7-aab8-94d0af6302be) Grid view example: ![output1](https://github.com/user-attachments/assets/997d54a6-d99d-477e-9417-80dc4211436d) Added base English translations for the new UI elements and Spanish translations aswell. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:00:45 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2657
No description provided.