[PR #2321] [MERGED] Fork detection: Fix Windows naming + add a new check for fork detection #2650

New issue

Closed

opened 2026-02-27 22:00:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2321
Author: @kalaposfos13
Created: 2/1/2025
Status: ✅ Merged
Merged: 2/3/2025
Merged by: @georgemoralis

Base: main ← Head: fork-detection-fix-2

📝 Commits (3)

927e87d Possible fix for Windows
398944c Check if remote.pushDefault is set when generating the remote link
48629b9 Remove left-in lines I missed before

📊 Changes

3 files changed (+27 additions, -8 deletions)

View changed files

📝 CMakeLists.txt (+13 -2)
📝 src/emulator.cpp (+7 -3)
📝 src/qt_gui/main_window.cpp (+7 -3)

📄 Description

I saw some screenshots on Discord which had the shadps4-emu/main text instead of just main in the window title, and I think this might be due to Windows handling Git remote links slightly differently, so I changed the code to first extract the name, and then check only that, instead of the full link. I don't actually know if this will fix the issue, but I certainly hope it will.

I also found a possible reason as to why @StevenMiller123's local builds fail to find the remote link even though his push defaults were set, and it is now included as the second thing to check if the branch doesn't explicitly have a remote pair defined.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2321 **Author:** [@kalaposfos13](https://github.com/kalaposfos13) **Created:** 2/1/2025 **Status:** ✅ Merged **Merged:** 2/3/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fork-detection-fix-2` --- ### 📝 Commits (3) - [`927e87d`](https://github.com/shadps4-emu/shadPS4/commit/927e87d5e82f0ebe66344395712e12dc41854812) Possible fix for Windows - [`398944c`](https://github.com/shadps4-emu/shadPS4/commit/398944c6ff538d245905f4a99361633ed1233633) Check if remote.pushDefault is set when generating the remote link - [`48629b9`](https://github.com/shadps4-emu/shadPS4/commit/48629b91d1788b177f3a0db24442a721a6baf5a9) Remove left-in lines I missed before ### 📊 Changes **3 files changed** (+27 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+13 -2) 📝 `src/emulator.cpp` (+7 -3) 📝 `src/qt_gui/main_window.cpp` (+7 -3) </details> ### 📄 Description I saw some screenshots on Discord which had the shadps4-emu/main text instead of just main in the window title, and I think this might be due to Windows handling Git remote links slightly differently, so I changed the code to first extract the name, and then check only that, instead of the full link. I don't actually know if this will fix the issue, but I certainly hope it will. ![image](https://github.com/user-attachments/assets/da649e15-6e50-4cc1-a67e-0ca207482d7a) I also found a possible reason as to why @StevenMiller123's local builds fail to find the remote link even though his push defaults were set, and it is now included as the second thing to check if the branch doesn't explicitly have a remote pair defined. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>