mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-25 15:56:00 +03:00
[PR #2254] [MERGED] Add Vulkan debug options to the Debug tab #2601
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#2601
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/shadps4-emu/shadPS4/pull/2254
Author: @tomboylover93
Created: 1/28/2025
Status: ✅ Merged
Merged: 1/30/2025
Merged by: @polybiusproxy
Base:
main← Head:advanced-debug📝 Commits (9)
9fee8a6Add Vulkan debug options to the Debug tab7564088Fix TRt (#2)584fc5csmall fixes to pt-BR translationaa434e8include name of options in description222e368en.ts fixa159feafix translations794076fMerge remote-tracking branch 'refs/remotes/origin/advanced-debug' into advanced-debug0b1e2e5fix rdoc translation3213ebbfix translations📊 Changes
39 files changed (+1518 additions, -153 deletions)
View changed files
📝
documents/building-linux.md(+1 -1)📝
src/common/config.cpp(+17 -7)📝
src/common/config.h(+6 -3)📝
src/emulator.cpp(+3 -3)📝
src/imgui/renderer/imgui_core.cpp(+2 -2)📝
src/imgui/renderer/texture_manager.cpp(+1 -1)📝
src/qt_gui/settings_dialog.cpp(+30 -1)📝
src/qt_gui/settings_dialog.ui(+188 -98)📝
src/qt_gui/translations/ar.ts(+44 -0)📝
src/qt_gui/translations/da_DK.ts(+44 -0)📝
src/qt_gui/translations/de.ts(+44 -0)📝
src/qt_gui/translations/el.ts(+44 -0)📝
src/qt_gui/translations/en.ts(+46 -1)📝
src/qt_gui/translations/es_ES.ts(+44 -0)📝
src/qt_gui/translations/fa_IR.ts(+44 -0)📝
src/qt_gui/translations/fi.ts(+44 -0)📝
src/qt_gui/translations/fr.ts(+44 -0)📝
src/qt_gui/translations/hu_HU.ts(+44 -0)📝
src/qt_gui/translations/id.ts(+44 -0)📝
src/qt_gui/translations/it.ts(+44 -0)...and 19 more files
📄 Description
This adds Crash Diagnostics, Collect Shaders, Copy GPU Buffers, Host Debug Markers and Guest Debug Markers to an "Advanced" section in the Debug tab, all with proper descriptions. It mainly helps developers who might want to get more info about an error beyond a simple log from a user, as now these options are more easily accessible.
This comes with one caveat: I couldn't make the config values work with a QCheckBox element as they were, so I changed them (example: vkCrashDiagnosticEnabled is now getVkCrashDiagnosticEnabled, and I added setVkCrashDiagnosticEnabled). As such, I changed every instance where they're used. This might cause issues with how these options are supposed to work, so please let me know if there are any.
Other than that, you now have to manually enable Host and Guest Debug Markers when using Crash Diagnostics, whereas currently if you have Crash Diagnostics enabled these are automatically enabled. This is because they did not automatically disable when disabling Crash Diagnostics from the Settings menu.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.