[PR #2243] [MERGED] qt: Prevent interacting with empty grid cells. #2590

New issue

Closed

opened 2026-02-27 22:00:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2243
Author: @squidbus
Created: 1/26/2025
Status: ✅ Merged
Merged: 1/26/2025
Merged by: @squidbus

Base: main ← Head: qt-fix

📝 Commits (1)

70d8f6f qt: Prevent interacting with empty grid cells.

📊 Changes

2 files changed (+4 additions, -3 deletions)

View changed files

📝 src/qt_gui/game_grid_frame.cpp (+2 -1)
📝 src/qt_gui/gui_context_menus.h (+2 -2)

📄 Description

Prevent interacting with empty cells in the game grid view, to prevent actions on out-of-bounds game list reads with potentially destructive results. Unfortunately I am not familiar enough with Qt to figure out how to disable selecting the empty cells that pad out rows to the number of grid columns, but this will at least prevent it from causing harm.

Should prevent https://github.com/shadps4-emu/shadPS4/issues/2242

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2243 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/26/2025 **Status:** ✅ Merged **Merged:** 1/26/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `qt-fix` --- ### 📝 Commits (1) - [`70d8f6f`](https://github.com/shadps4-emu/shadPS4/commit/70d8f6f050c6a36a4e0244ead1cc6a3d36939263) qt: Prevent interacting with empty grid cells. ### 📊 Changes **2 files changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/game_grid_frame.cpp` (+2 -1) 📝 `src/qt_gui/gui_context_menus.h` (+2 -2) </details> ### 📄 Description Prevent interacting with empty cells in the game grid view, to prevent actions on out-of-bounds game list reads with potentially destructive results. Unfortunately I am not familiar enough with Qt to figure out how to disable selecting the empty cells that pad out rows to the number of grid columns, but this will at least prevent it from causing harm. Should prevent https://github.com/shadps4-emu/shadPS4/issues/2242 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>