[PR #2227] [MERGED] liverpool: Fix tiled check for color buffer. #2577

New issue

Closed

opened 2026-02-27 22:00:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2227
Author: @squidbus
Created: 1/24/2025
Status: ✅ Merged
Merged: 1/24/2025
Merged by: @georgemoralis

Base: main ← Head: tiled-fix

📝 Commits (1)

9ef8cb2 liverpool: Fix tiled check for color buffer.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/video_core/amdgpu/liverpool.h (+1 -1)

📄 Description

Fix the IsTiled() check for color buffers. The linear_general flag overrides the array mode to linear general, but the tiling mode can also just be Display_Linear even if linear_general is not set. So instead of checking that flag, just delegate to GetTilingMode() and check if not Display_Linear.

In practice I don't think this changes much since we don't do much display tiling, but should stop some spam for unsupported tiling mode Display_Linear, which shouldn't be going through the detiling code at all.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2227 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/24/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `tiled-fix` --- ### 📝 Commits (1) - [`9ef8cb2`](https://github.com/shadps4-emu/shadPS4/commit/9ef8cb2f2e3eea61d47f065b8f49572c65febf41) liverpool: Fix tiled check for color buffer. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/amdgpu/liverpool.h` (+1 -1) </details> ### 📄 Description Fix the `IsTiled()` check for color buffers. The `linear_general` flag overrides the array mode to linear general, but the tiling mode can also just be `Display_Linear` even if `linear_general` is not set. So instead of checking that flag, just delegate to `GetTilingMode()` and check if not `Display_Linear`. In practice I don't think this changes much since we don't do much display tiling, but should stop some spam for unsupported tiling mode `Display_Linear`, which shouldn't be going through the detiling code at all. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>