[PR #2217] [MERGED] texture_cache: Do not overwrite overlap hit with a miss. #2570

New issue

Closed

opened 2026-02-27 22:00:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2217
Author: @squidbus
Created: 1/23/2025
Status: ✅ Merged
Merged: 1/24/2025
Merged by: @georgemoralis

Base: main ← Head: depth-view

📝 Commits (1)

85feaa7 texture_cache: Do not overwrite overlap hit with a miss.

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 src/video_core/texture_cache/texture_cache.cpp (+6 -1)

📄 Description

When resolving overlaps, don't overwrite an overlap hit with a miss.

Fixes fog effect in battles in CUSA16404 incorrectly covering the entire screen. The depth buffer was not being matched and instead a new, empty color image was being created.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2217 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/23/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `depth-view` --- ### 📝 Commits (1) - [`85feaa7`](https://github.com/shadps4-emu/shadPS4/commit/85feaa7b8c2086af3953c58b52a6e79ccc40ab0e) texture_cache: Do not overwrite overlap hit with a miss. ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/texture_cache/texture_cache.cpp` (+6 -1) </details> ### 📄 Description When resolving overlaps, don't overwrite an overlap hit with a miss. Fixes fog effect in battles in CUSA16404 incorrectly covering the entire screen. The depth buffer was not being matched and instead a new, empty color image was being created. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>