[PR #2203] [MERGED] tile: Fix some tile thickness calculation errors. #2560

New issue

Closed

opened 2026-02-27 22:00:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2203
Author: @squidbus
Created: 1/22/2025
Status: ✅ Merged
Merged: 1/22/2025
Merged by: @psucien

Base: main ← Head: tile-fix-2

📝 Commits (2)

bc344e4 tile: Fix some tile thickness calculation errors.
b1e3547 tile: Do not pad mip height to tile height.

📊 Changes

2 files changed (+8 additions, -9 deletions)

View changed files

📝 src/video_core/texture_cache/image_info.cpp (+6 -7)
📝 src/video_core/texture_cache/tile.h (+2 -2)

📄 Description

Fix some mistakes from updates to tile calculations related to volume thickness:

Typo in arg order to ImageSizeMicroTiled in UpdateSize.
ImageSizeMicroTiled should not return size multiplied with thickness, only use it for pitch alignment padding condition. Returned value will be multiplied with full texture depth after.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2203 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/22/2025 **Status:** ✅ Merged **Merged:** 1/22/2025 **Merged by:** [@psucien](https://github.com/psucien) **Base:** `main` ← **Head:** `tile-fix-2` --- ### 📝 Commits (2) - [`bc344e4`](https://github.com/shadps4-emu/shadPS4/commit/bc344e4a5279e9f2c6cc7382c5e335cbdc45fb30) tile: Fix some tile thickness calculation errors. - [`b1e3547`](https://github.com/shadps4-emu/shadPS4/commit/b1e3547ccc4718dc0ae81cbacb41a0ce72fec1f3) tile: Do not pad mip height to tile height. ### 📊 Changes **2 files changed** (+8 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/texture_cache/image_info.cpp` (+6 -7) 📝 `src/video_core/texture_cache/tile.h` (+2 -2) </details> ### 📄 Description Fix some mistakes from updates to tile calculations related to volume thickness: * Typo in arg order to `ImageSizeMicroTiled` in `UpdateSize`. * `ImageSizeMicroTiled` should not return size multiplied with thickness, only use it for pitch alignment padding condition. Returned value will be multiplied with full texture depth after. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>