[PR #2202] [MERGED] address_space: Fix initialization on Windows #2557

New issue

Closed

opened 2026-02-27 22:00:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2202
Author: @StevenMiller123
Created: 1/21/2025
Status: ✅ Merged
Merged: 1/22/2025
Merged by: @georgemoralis

Base: main ← Head: fix-address-space

📝 Commits (1)

9b95d3e Fix for address_space initialization on Windows

📊 Changes

1 file changed (+6 additions, -11 deletions)

View changed files

📝 src/core/address_space.cpp (+6 -11)

📄 Description

This fixes an issue where our initial placeholder mapping didn't align with the region we tracked. This should fix some cases of

[Debug] <Critical> address_space.cpp:JoinRegionsAfterUnmap:292: Unreachable code!
Region coalescing failed: Attempt to access invalid address.

Credits to @raphaelthegreat for providing the initial code for this PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2202 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 1/21/2025 **Status:** ✅ Merged **Merged:** 1/22/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fix-address-space` --- ### 📝 Commits (1) - [`9b95d3e`](https://github.com/shadps4-emu/shadPS4/commit/9b95d3e236a4f0de1d32020634d43b65acb6fc38) Fix for address_space initialization on Windows ### 📊 Changes **1 file changed** (+6 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/core/address_space.cpp` (+6 -11) </details> ### 📄 Description This fixes an issue where our initial placeholder mapping didn't align with the region we tracked. This should fix some cases of ``` [Debug] <Critical> address_space.cpp:JoinRegionsAfterUnmap:292: Unreachable code! Region coalescing failed: Attempt to access invalid address. ``` Credits to @raphaelthegreat for providing the initial code for this PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>