[PR #2196] [MERGED] texture_cache: Prevent unregistered images from being tracked. #2552

New issue

Closed

opened 2026-02-27 22:00:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2196
Author: @squidbus
Created: 1/20/2025
Status: ✅ Merged
Merged: 1/20/2025
Merged by: @psucien

Base: main ← Head: texcache-freeze

📝 Commits (1)

a06fcc6 texture_cache: Prevent unregistered images from being tracked.

📊 Changes

1 file changed (+9 additions, -0 deletions)

View changed files

📝 src/video_core/texture_cache/texture_cache.cpp (+9 -0)

📄 Description

Do not allow images that have been unregistered to be re-tracked. This could happen if an image is unregistered but not deleted until scheduler reaches tick, and then another piece of code updates the image ID before it is deleted. If this happens and the image then gets deleted from the image slots, it will leave dead page tracking ref-count and leave the page unable to be untracked for writes.

Fixes some loading stalls in CUSA28193

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2196 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/20/2025 **Status:** ✅ Merged **Merged:** 1/20/2025 **Merged by:** [@psucien](https://github.com/psucien) **Base:** `main` ← **Head:** `texcache-freeze` --- ### 📝 Commits (1) - [`a06fcc6`](https://github.com/shadps4-emu/shadPS4/commit/a06fcc6a722174f95611477b4774febce2e3f991) texture_cache: Prevent unregistered images from being tracked. ### 📊 Changes **1 file changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/texture_cache/texture_cache.cpp` (+9 -0) </details> ### 📄 Description Do not allow images that have been unregistered to be re-tracked. This could happen if an image is unregistered but not deleted until scheduler reaches tick, and then another piece of code updates the image ID before it is deleted. If this happens and the image then gets deleted from the image slots, it will leave dead page tracking ref-count and leave the page unable to be untracked for writes. Fixes some loading stalls in CUSA28193 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>