[PR #2176] [MERGED] renderer_vulkan: Remove swapchain image reinterpretation. #2538

Closed
opened 2026-02-27 22:00:19 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2176
Author: @squidbus
Created: 1/18/2025
Status: Merged
Merged: 1/18/2025
Merged by: @squidbus

Base: mainHead: fix-swap


📝 Commits (1)

  • 084bf18 renderer_vulkan: Remove swapchain image reinterpretation.

📊 Changes

4 files changed (+5 additions, -33 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_instance.cpp (+0 -1)
📝 src/video_core/renderer_vulkan/vk_presenter.cpp (+1 -1)
📝 src/video_core/renderer_vulkan/vk_swapchain.cpp (+4 -16)
📝 src/video_core/renderer_vulkan/vk_swapchain.h (+0 -15)

📄 Description

Instead of reinterpreting swapchain image as unorm in the image view, just select a unorm swapchain format to begin with.

Fixes blank or flickering screen on macOS.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2176 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/18/2025 **Status:** ✅ Merged **Merged:** 1/18/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `fix-swap` --- ### 📝 Commits (1) - [`084bf18`](https://github.com/shadps4-emu/shadPS4/commit/084bf1881407a96f050bad3af7726abcbb084019) renderer_vulkan: Remove swapchain image reinterpretation. ### 📊 Changes **4 files changed** (+5 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+0 -1) 📝 `src/video_core/renderer_vulkan/vk_presenter.cpp` (+1 -1) 📝 `src/video_core/renderer_vulkan/vk_swapchain.cpp` (+4 -16) 📝 `src/video_core/renderer_vulkan/vk_swapchain.h` (+0 -15) </details> ### 📄 Description Instead of reinterpreting swapchain image as unorm in the image view, just select a unorm swapchain format to begin with. Fixes blank or flickering screen on macOS. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:00:19 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2538
No description provided.