[PR #2169] [MERGED] renderer_vulkan: Fix present related validation errors. #2529

New issue

Closed

opened 2026-02-27 22:00:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2169
Author: @squidbus
Created: 1/17/2025
Status: ✅ Merged
Merged: 1/17/2025
Merged by: @georgemoralis

Base: main ← Head: fix-present

📝 Commits (1)

3dd90a3 renderer_vulkan: Fix present related validation errors.

📊 Changes

6 files changed (+28 additions, -9 deletions)

View changed files

📝 src/imgui/renderer/imgui_impl_vulkan.cpp (+1 -4)
📝 src/imgui/renderer/imgui_impl_vulkan.h (+0 -1)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+1 -1)
📝 src/video_core/renderer_vulkan/vk_presenter.cpp (+8 -2)
📝 src/video_core/renderer_vulkan/vk_swapchain.cpp (+13 -1)
📝 src/video_core/renderer_vulkan/vk_swapchain.h (+5 -0)

📄 Description

Fixes some validation errors from new ImGui present logic:

setColorBlendEnableEXT is not always available, instead just swizzle alpha to one when blitting frame to disable alpha.
Make swapchain image format mutable and provide correct format to ImGui, to properly use non-SRGB image view.

Does not resolve issue on some platforms where rendering is empty.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2169 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/17/2025 **Status:** ✅ Merged **Merged:** 1/17/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fix-present` --- ### 📝 Commits (1) - [`3dd90a3`](https://github.com/shadps4-emu/shadPS4/commit/3dd90a323c14791b7e357e9c880888d386e51048) renderer_vulkan: Fix present related validation errors. ### 📊 Changes **6 files changed** (+28 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/imgui/renderer/imgui_impl_vulkan.cpp` (+1 -4) 📝 `src/imgui/renderer/imgui_impl_vulkan.h` (+0 -1) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+1 -1) 📝 `src/video_core/renderer_vulkan/vk_presenter.cpp` (+8 -2) 📝 `src/video_core/renderer_vulkan/vk_swapchain.cpp` (+13 -1) 📝 `src/video_core/renderer_vulkan/vk_swapchain.h` (+5 -0) </details> ### 📄 Description Fixes some validation errors from new ImGui present logic: * `setColorBlendEnableEXT` is not always available, instead just swizzle alpha to one when blitting frame to disable alpha. * Make swapchain image format mutable and provide correct format to ImGui, to properly use non-SRGB image view. Does not resolve issue on some platforms where rendering is empty. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>