[PR #2161] [MERGED] network: Remove firing Np callbacks from check stubs. #2525

New issue

Closed

opened 2026-02-27 22:00:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2161
Author: @squidbus
Created: 1/16/2025
Status: ✅ Merged
Merged: 1/16/2025
Merged by: @georgemoralis

Base: main ← Head: np-fix

📝 Commits (1)

3232031 network: Remove firing Np callbacks from check stubs.

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 src/core/libraries/network/netctl.cpp (+2 -2)
📝 src/core/libraries/np_manager/np_manager.cpp (+1 -1)

📄 Description

Np callbacks are intended to be called when an event occurs and probably should not be spammed every time the game requests checking for events. Removing the calls from these stubs seems to fix general instability I have where the thread Toolkit::NP::MainThread from libSceNpToolkit2 would crash randomly in sceLibcMspaceFree.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2161 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/16/2025 **Status:** ✅ Merged **Merged:** 1/16/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `np-fix` --- ### 📝 Commits (1) - [`3232031`](https://github.com/shadps4-emu/shadPS4/commit/32320316e6de90e1592ff1cbeaa3a8fc1c76ebcb) network: Remove firing Np callbacks from check stubs. ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/network/netctl.cpp` (+2 -2) 📝 `src/core/libraries/np_manager/np_manager.cpp` (+1 -1) </details> ### 📄 Description Np callbacks are intended to be called when an event occurs and probably should not be spammed every time the game requests checking for events. Removing the calls from these stubs seems to fix general instability I have where the thread `Toolkit::NP::MainThread` from `libSceNpToolkit2` would crash randomly in `sceLibcMspaceFree`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>