[PR #2159] [MERGED] renderer_vulkan: Simplify debug marker settings. #2523

New issue

Closed

opened 2026-02-27 22:00:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2159
Author: @squidbus
Created: 1/16/2025
Status: ✅ Merged
Merged: 1/16/2025
Merged by: @georgemoralis

Base: main ← Head: markers-cleanup

📝 Commits (4)

c6b32ed renderer_vulkan: Simplify debug marker settings.
52caa3a liverpool: Add scope markers for graphics/compute queues.
5db09c7 liverpool: Remove unneeded extra label from command buffer markers.
433d946 vk_rasterizer: Add scopes around filtered draw passes.

📊 Changes

14 files changed (+132 additions, -98 deletions)

View changed files

📝 src/common/config.cpp (+22 -16)
📝 src/common/config.h (+2 -1)
📝 src/emulator.cpp (+3 -2)
📝 src/imgui/renderer/imgui_core.cpp (+2 -2)
📝 src/video_core/amdgpu/liverpool.cpp (+29 -17)
📝 src/video_core/buffer_cache/buffer.cpp (+2 -0)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+3 -8)
📝 src/video_core/renderer_vulkan/vk_instance.h (+1 -10)
📝 src/video_core/renderer_vulkan/vk_platform.h (+7 -0)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+40 -22)
📝 src/video_core/renderer_vulkan/vk_rasterizer.h (+5 -4)
📝 src/video_core/renderer_vulkan/vk_resource_pool.cpp (+3 -7)
📝 src/video_core/renderer_vulkan/vk_swapchain.cpp (+6 -9)
📝 src/video_core/texture_cache/image_view.cpp (+7 -0)

📄 Description

Currently emitting debug names/markers is gated behind a confusing mix of conditions like whether certain tools are attached, settings named after tools like RenderDoc that they actually have nothing to do with, etc.

This PR simplifies things down to just two settings with very clear purpose: a setting to enable host-provided debug markers, and a setting to enable guest-provided debug markers. When host markers are enabled, debug names and markers provided by the emulator will be emitted. When guest markers are enabled, debug markers provided by the guest in the command buffer will be emitted.

Both types of markers are forced on when crash diagnostics are enabled at the config level, similar to before. We can force them on based on other settings as well if we decide it is warranted.

This also adds debug names to image and buffer views, which are useful to me and part of the motivation for this change: putting names on every created view could be expensive, and I wanted clear settings to gate this behavior behind.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2159 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/16/2025 **Status:** ✅ Merged **Merged:** 1/16/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `markers-cleanup` --- ### 📝 Commits (4) - [`c6b32ed`](https://github.com/shadps4-emu/shadPS4/commit/c6b32edefde470b76b6c83d763c7c00d8a7fc1a3) renderer_vulkan: Simplify debug marker settings. - [`52caa3a`](https://github.com/shadps4-emu/shadPS4/commit/52caa3a8878ab144fa3eaf59148dcd0b269387eb) liverpool: Add scope markers for graphics/compute queues. - [`5db09c7`](https://github.com/shadps4-emu/shadPS4/commit/5db09c7c9046360d58607d3d7e330fd6b9bf1cff) liverpool: Remove unneeded extra label from command buffer markers. - [`433d946`](https://github.com/shadps4-emu/shadPS4/commit/433d946b3ff375e69989ead7c3bae80cea8ff5bb) vk_rasterizer: Add scopes around filtered draw passes. ### 📊 Changes **14 files changed** (+132 additions, -98 deletions) <details> <summary>View changed files</summary> 📝 `src/common/config.cpp` (+22 -16) 📝 `src/common/config.h` (+2 -1) 📝 `src/emulator.cpp` (+3 -2) 📝 `src/imgui/renderer/imgui_core.cpp` (+2 -2) 📝 `src/video_core/amdgpu/liverpool.cpp` (+29 -17) 📝 `src/video_core/buffer_cache/buffer.cpp` (+2 -0) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+3 -8) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+1 -10) 📝 `src/video_core/renderer_vulkan/vk_platform.h` (+7 -0) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+40 -22) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.h` (+5 -4) 📝 `src/video_core/renderer_vulkan/vk_resource_pool.cpp` (+3 -7) 📝 `src/video_core/renderer_vulkan/vk_swapchain.cpp` (+6 -9) 📝 `src/video_core/texture_cache/image_view.cpp` (+7 -0) </details> ### 📄 Description Currently emitting debug names/markers is gated behind a confusing mix of conditions like whether certain tools are attached, settings named after tools like RenderDoc that they actually have nothing to do with, etc. This PR simplifies things down to just two settings with very clear purpose: a setting to enable host-provided debug markers, and a setting to enable guest-provided debug markers. When host markers are enabled, debug names and markers provided by the emulator will be emitted. When guest markers are enabled, debug markers provided by the guest in the command buffer will be emitted. Both types of markers are forced on when crash diagnostics are enabled at the config level, similar to before. We can force them on based on other settings as well if we decide it is warranted. This also adds debug names to image and buffer views, which are useful to me and part of the motivation for this change: putting names on every created view could be expensive, and I wanted clear settings to gate this behavior behind. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>