[PR #2138] [MERGED] sdl: Respect text input main thread requirements. #2512

New issue

Closed

opened 2026-02-27 22:00:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2138
Author: @squidbus
Created: 1/12/2025
Status: ✅ Merged
Merged: 1/12/2025
Merged by: @georgemoralis

Base: main ← Head: sdl-thread

📝 Commits (1)

a48e6cc sdl: Respect text input main thread requirements.

📊 Changes

3 files changed (+23 additions, -28 deletions)

View changed files

📝 externals/sdl3 (+1 -1)
📝 src/imgui/renderer/imgui_impl_sdl3.cpp (+16 -25)
📝 src/sdl_window.cpp (+6 -2)

📄 Description

Some SDL text input functions are documented to be required to run on the main SDL thread. Update SDL to the latest versioned release and use the new SDL_RunOnMainThread to respect this requirement.

Existing code for this in the ImGui SDL backend is also updated to use this instead of dispatches on macOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2138 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/12/2025 **Status:** ✅ Merged **Merged:** 1/12/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `sdl-thread` --- ### 📝 Commits (1) - [`a48e6cc`](https://github.com/shadps4-emu/shadPS4/commit/a48e6cc57f86483d86c4350dfc21f92b3d50695e) sdl: Respect text input main thread requirements. ### 📊 Changes **3 files changed** (+23 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `externals/sdl3` (+1 -1) 📝 `src/imgui/renderer/imgui_impl_sdl3.cpp` (+16 -25) 📝 `src/sdl_window.cpp` (+6 -2) </details> ### 📄 Description Some SDL text input functions are documented to be required to run on the main SDL thread. Update SDL to the latest versioned release and use the new `SDL_RunOnMainThread` to respect this requirement. Existing code for this in the ImGui SDL backend is also updated to use this instead of dispatches on macOS. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>