[PR #2114] [MERGED] Implement sceNpCmp functions #2498

New issue

Closed

opened 2026-02-27 22:00:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2114
Author: @StevenMiller123
Created: 1/10/2025
Status: ✅ Merged
Merged: 1/11/2025
Merged by: @polybiusproxy

Base: main ← Head: missing-np-stubs

📝 Commits (10+)

7701bf3 NpCommon stubs
041eb0e Params for NpCmp functions
f2c3010 fix
2337c4a Implement sceNpCmp functions
6d9dc2a fix sceNpCmpNpIdInOrder
35b7ac2 Fix indentation
7625b36 Clang pt 1
45ef040 Clang pt 2
fdd34cb Clang
69a1725 Clang

📊 Changes

8 files changed (+9176 additions, -2 deletions)

View changed files

📝 CMakeLists.txt (+3 -1)
📝 src/common/logging/filter.cpp (+1 -0)
📝 src/common/logging/types.h (+1 -0)
📝 src/core/libraries/libs.cpp (+2 -0)
➕ src/core/libraries/np_common/np_common.cpp (+7915 -0)
➕ src/core/libraries/np_common/np_common.h (+1245 -0)
➕ src/core/libraries/np_common/np_common_error.h (+9 -0)
📝 src/core/libraries/np_manager/np_manager.cpp (+0 -1)

📄 Description

This PR implements sceNpCmpNpId, sceNpCmpNpIdInOrder, and sceNpCmpOnlineId based on decompiled behavior. Since libSceNpCommon hadn't been added yet, I've also included auto generated stubs for the rest of the library's functions.
This probably won't improve compatibility for anything, but it should decrease stub spam in some games.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2114 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 1/10/2025 **Status:** ✅ Merged **Merged:** 1/11/2025 **Merged by:** [@polybiusproxy](https://github.com/polybiusproxy) **Base:** `main` ← **Head:** `missing-np-stubs` --- ### 📝 Commits (10+) - [`7701bf3`](https://github.com/shadps4-emu/shadPS4/commit/7701bf3f54fb4d300d12a0e008b070530c69d99b) NpCommon stubs - [`041eb0e`](https://github.com/shadps4-emu/shadPS4/commit/041eb0e939b3fb68b2e423e092a318eed9933073) Params for NpCmp functions - [`f2c3010`](https://github.com/shadps4-emu/shadPS4/commit/f2c3010eb4c867a0e4d928370527ba12f12ddb8f) fix - [`2337c4a`](https://github.com/shadps4-emu/shadPS4/commit/2337c4a6859cb261bad7e56e16aa6e1594698351) Implement sceNpCmp functions - [`6d9dc2a`](https://github.com/shadps4-emu/shadPS4/commit/6d9dc2adc35a37a8ac95e29e57da00650d44c917) fix sceNpCmpNpIdInOrder - [`35b7ac2`](https://github.com/shadps4-emu/shadPS4/commit/35b7ac24fe270ac1dd562e076d71dab00e79426b) Fix indentation - [`7625b36`](https://github.com/shadps4-emu/shadPS4/commit/7625b36dc272daa2df51b40b2d6288c3e28bad0f) Clang pt 1 - [`45ef040`](https://github.com/shadps4-emu/shadPS4/commit/45ef0407baa9f634ae71c12dad430ec52c14736a) Clang pt 2 - [`fdd34cb`](https://github.com/shadps4-emu/shadPS4/commit/fdd34cbe1f83068ae16c6eafdcea4846cd467540) Clang - [`69a1725`](https://github.com/shadps4-emu/shadPS4/commit/69a1725a36cb807ba12bd6d152640cbafd0d20ec) Clang ### 📊 Changes **8 files changed** (+9176 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+3 -1) 📝 `src/common/logging/filter.cpp` (+1 -0) 📝 `src/common/logging/types.h` (+1 -0) 📝 `src/core/libraries/libs.cpp` (+2 -0) ➕ `src/core/libraries/np_common/np_common.cpp` (+7915 -0) ➕ `src/core/libraries/np_common/np_common.h` (+1245 -0) ➕ `src/core/libraries/np_common/np_common_error.h` (+9 -0) 📝 `src/core/libraries/np_manager/np_manager.cpp` (+0 -1) </details> ### 📄 Description This PR implements sceNpCmpNpId, sceNpCmpNpIdInOrder, and sceNpCmpOnlineId based on decompiled behavior. Since libSceNpCommon hadn't been added yet, I've also included auto generated stubs for the rest of the library's functions. This probably won't improve compatibility for anything, but it should decrease stub spam in some games. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>