[PR #2104] [MERGED] renderer_vulkan: Simplify vertex binding logic and properly handle null buffers. #2493

New issue

Closed

opened 2026-02-27 22:00:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2104
Author: @squidbus
Created: 1/9/2025
Status: ✅ Merged
Merged: 1/10/2025
Merged by: @georgemoralis

Base: main ← Head: vertex-fixes

📝 Commits (2)

ae92e9c renderer_vulkan: Simplify vertex binding logic and properly handle null buffers.
2caca8b renderer_vulkan: Remove need for empty bindVertexBuffers2EXT.

📊 Changes

6 files changed (+137 additions, -138 deletions)

View changed files

📝 src/video_core/buffer_cache/buffer_cache.cpp (+64 -94)
📝 src/video_core/buffer_cache/buffer_cache.h (+5 -4)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+51 -30)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.h (+9 -0)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+4 -4)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+4 -6)

📄 Description

Simplifies vertex binding logic by using common code for creating the required attribute and binding structures, for both the dynamic vertex input and pipeline vertex input paths.
Handles unbound vertex buffers using null buffer instead of skipping binding, which could lead to missing vertex attribute bindings for the shader.

Fixes a crash in CUSA05637 halfway through the 7th stage.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2104 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/9/2025 **Status:** ✅ Merged **Merged:** 1/10/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `vertex-fixes` --- ### 📝 Commits (2) - [`ae92e9c`](https://github.com/shadps4-emu/shadPS4/commit/ae92e9c5a0a29bcb5bc4a161200c0d87c093f1de) renderer_vulkan: Simplify vertex binding logic and properly handle null buffers. - [`2caca8b`](https://github.com/shadps4-emu/shadPS4/commit/2caca8b68de7ba9110f6e4d7b6cd4e3114b50840) renderer_vulkan: Remove need for empty bindVertexBuffers2EXT. ### 📊 Changes **6 files changed** (+137 additions, -138 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/buffer_cache/buffer_cache.cpp` (+64 -94) 📝 `src/video_core/buffer_cache/buffer_cache.h` (+5 -4) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+51 -30) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.h` (+9 -0) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+4 -4) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+4 -6) </details> ### 📄 Description * Simplifies vertex binding logic by using common code for creating the required attribute and binding structures, for both the dynamic vertex input and pipeline vertex input paths. * Handles unbound vertex buffers using null buffer instead of skipping binding, which could lead to missing vertex attribute bindings for the shader. Fixes a crash in CUSA05637 halfway through the 7th stage. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>