[PR #2079] [MERGED] renderer_vulkan: Fix null buffer views with wrong format. #2475

New issue

Closed

opened 2026-02-27 21:59:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:59:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2079
Author: @squidbus
Created: 1/7/2025
Status: ✅ Merged
Merged: 1/7/2025
Merged by: @georgemoralis

Base: main ← Head: fix-null-buf

📝 Commits (1)

dcfd3cc renderer_vulkan: Fix null buffer views with wrong format.

📊 Changes

3 files changed (+16 additions, -26 deletions)

View changed files

📝 src/video_core/buffer_cache/buffer_cache.cpp (+1 -12)
📝 src/video_core/buffer_cache/buffer_cache.h (+0 -5)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+15 -9)

📄 Description

Using null buffer view as-is can result in a validation error when the format does not match the number type that the shader expects. Instead, create a view of the null buffer with the expected format as needed. Null buffer is also expanded to size 16 to cover the necessary format sizes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2079 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/7/2025 **Status:** ✅ Merged **Merged:** 1/7/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fix-null-buf` --- ### 📝 Commits (1) - [`dcfd3cc`](https://github.com/shadps4-emu/shadPS4/commit/dcfd3cceb44675a2bebb7ab8544b4a287a8a1181) renderer_vulkan: Fix null buffer views with wrong format. ### 📊 Changes **3 files changed** (+16 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/buffer_cache/buffer_cache.cpp` (+1 -12) 📝 `src/video_core/buffer_cache/buffer_cache.h` (+0 -5) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+15 -9) </details> ### 📄 Description Using null buffer view as-is can result in a validation error when the format does not match the number type that the shader expects. Instead, create a view of the null buffer with the expected format as needed. Null buffer is also expanded to size 16 to cover the necessary format sizes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>