[PR #2066] [MERGED] vk_instance: Enable additional debug tagging if crash diagnostics is enabled. #2468

Closed
opened 2026-02-27 21:16:37 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2066
Author: @squidbus
Created: 1/5/2025
Status: Merged
Merged: 1/5/2025
Merged by: @georgemoralis

Base: mainHead: crash-labels


📝 Commits (1)

  • b6e8bef vk_instance: Enable additional debug tagging if crash diagnostics is enabled.

📊 Changes

2 files changed (+6 additions, -3 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_instance.cpp (+4 -2)
📝 src/video_core/renderer_vulkan/vk_instance.h (+2 -1)

📄 Description

Some additional object debug labels are only applied if a debugging tool is attached. Consider enabled crash diagnostics as permitting adding this additional labeling, to provide more info in the output.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2066 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/5/2025 **Status:** ✅ Merged **Merged:** 1/5/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `crash-labels` --- ### 📝 Commits (1) - [`b6e8bef`](https://github.com/shadps4-emu/shadPS4/commit/b6e8befa0ac3d7186787ce91e1165bdd1972d485) vk_instance: Enable additional debug tagging if crash diagnostics is enabled. ### 📊 Changes **2 files changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+4 -2) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+2 -1) </details> ### 📄 Description Some additional object debug labels are only applied if a debugging tool is attached. Consider enabled crash diagnostics as permitting adding this additional labeling, to provide more info in the output. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 21:16:37 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2468
No description provided.