[PR #2032] [CLOSED] renderer_vulkan: Don't crash if Depth Format is not recognized #2452

Closed
opened 2026-02-27 21:16:34 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2032
Author: @Xphalnos
Created: 1/3/2025
Status: Closed

Base: mainHead: Fix_PromoteFormatToDepth_Crash


📝 Commits (1)

  • 7110e2c renderer_vulkan: Don't crash if Depth Format is not recognized

📊 Changes

1 file changed (+8 additions, -4 deletions)

View changed files

📝 src/video_core/renderer_vulkan/liverpool_to_vk.h (+8 -4)

📄 Description

While it can't override Depth Format, this allows games to not crash due to this error.
Fixes PC Building Simulator and probably other games.

PC Building Simulator with this PR:
Capture d'écran 2025-01-03 180659
Capture d'écran 2025-01-03 180723


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2032 **Author:** [@Xphalnos](https://github.com/Xphalnos) **Created:** 1/3/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `Fix_PromoteFormatToDepth_Crash` --- ### 📝 Commits (1) - [`7110e2c`](https://github.com/shadps4-emu/shadPS4/commit/7110e2c1de1ede4346154ff69e23a9bd8a975496) renderer_vulkan: Don't crash if Depth Format is not recognized ### 📊 Changes **1 file changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.h` (+8 -4) </details> ### 📄 Description While it can't override Depth Format, this allows games to not crash due to this error. Fixes **PC Building Simulator** and probably other games. **PC Building Simulator** with this PR: ![Capture d'écran 2025-01-03 180659](https://github.com/user-attachments/assets/25046e5c-3c74-4430-a502-7986bc580bb8) ![Capture d'écran 2025-01-03 180723](https://github.com/user-attachments/assets/cfbd6551-3fdd-4b33-81ba-e10ede64a561) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 21:16:34 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2452
No description provided.