[PR #1998] [MERGED] audio: Improve port state guards. #2428

New issue

Closed

opened 2026-02-27 21:16:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1998
Author: @squidbus
Created: 12/31/2024
Status: ✅ Merged
Merged: 1/2/2025
Merged by: @georgemoralis

Base: main ← Head: out-state

📝 Commits (1)

79437c1 audio: Improve port state guards.

📊 Changes

3 files changed (+103 additions, -83 deletions)

View changed files

📝 src/core/libraries/audio/audioout.cpp (+78 -73)
📝 src/core/libraries/audio/audioout.h (+7 -1)
📝 src/core/libraries/audio/sdl_audio.cpp (+18 -9)

📄 Description

Upgraded the output mutex of ports to a full port state mutex, updated port uses to hold this mutex, and added guards against port invalidation during port conditional variable waits.

Also, added some additional logging for the SDL audio stream buffer sizes and queue threshold.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1998 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/31/2024 **Status:** ✅ Merged **Merged:** 1/2/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `out-state` --- ### 📝 Commits (1) - [`79437c1`](https://github.com/shadps4-emu/shadPS4/commit/79437c1770f61fd005bf06ac41bc59e31c734970) audio: Improve port state guards. ### 📊 Changes **3 files changed** (+103 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/audio/audioout.cpp` (+78 -73) 📝 `src/core/libraries/audio/audioout.h` (+7 -1) 📝 `src/core/libraries/audio/sdl_audio.cpp` (+18 -9) </details> ### 📄 Description Upgraded the output mutex of ports to a full port state mutex, updated port uses to hold this mutex, and added guards against port invalidation during port conditional variable waits. Also, added some additional logging for the SDL audio stream buffer sizes and queue threshold. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>