[PR #1970] [MERGED] build: Update MoltenVK and fix missing add_dependencies for copy. #2414

New issue

Closed

opened 2026-02-27 21:16:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1970
Author: @squidbus
Created: 12/29/2024
Status: ✅ Merged
Merged: 12/29/2024
Merged by: @raphaelthegreat

Base: main ← Head: fix-mvk2

📝 Commits (2)

87fe9ac build: Fix missing add_dependencies for MoltenVK copy target.
90c22fb externals: Update MoltenVK

📊 Changes

2 files changed (+2 additions, -1 deletions)

View changed files

📝 CMakeLists.txt (+1 -0)
📝 externals/MoltenVK/MoltenVK (+1 -1)

📄 Description

Missed this before and caught it in a CI run in my fork today without cache. Apparently this target dependency needs to be added for it to know how to make the dylib file, adding the file dependency to the copy command isn't enough alone.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1970 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/29/2024 **Status:** ✅ Merged **Merged:** 12/29/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `fix-mvk2` --- ### 📝 Commits (2) - [`87fe9ac`](https://github.com/shadps4-emu/shadPS4/commit/87fe9ace6bbf13e547b491dd35026dc77232e88e) build: Fix missing add_dependencies for MoltenVK copy target. - [`90c22fb`](https://github.com/shadps4-emu/shadPS4/commit/90c22fb6cdaabdbf3963f89137e22df42d1cd0d3) externals: Update MoltenVK ### 📊 Changes **2 files changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+1 -0) 📝 `externals/MoltenVK/MoltenVK` (+1 -1) </details> ### 📄 Description Missed this before and caught it in a CI run in my fork today without cache. Apparently this target dependency needs to be added for it to know how to make the dylib file, adding the file dependency to the copy command isn't enough alone. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>