[PR #1962] [MERGED] recompiler: handle reads of output variables in hull shaders #2405

New issue

Closed

opened 2026-02-27 21:16:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1962
Author: @baggins183
Created: 12/29/2024
Status: ✅ Merged
Merged: 12/29/2024
Merged by: @raphaelthegreat

Base: main ← Head: tess-output-reads

📝 Commits (3)

7737115 Handle output control point reads in hull shader. Might need additional barriers
3e75cc6 output storage class
c244a97 Merge branch 'shadps4-emu:main' into tess-output-reads

📊 Changes

7 files changed (+38 additions, -22 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp (+7 -8)
📝 src/shader_recompiler/backend/spirv/emit_spirv_instructions.h (+2 -0)
📝 src/shader_recompiler/frontend/translate/vector_memory.cpp (+0 -4)
📝 src/shader_recompiler/ir/ir_emitter.cpp (+6 -0)
📝 src/shader_recompiler/ir/ir_emitter.h (+3 -0)
📝 src/shader_recompiler/ir/opcodes.inc (+2 -0)
📝 src/shader_recompiler/ir/passes/hull_shader_transform.cpp (+18 -10)

📄 Description

Adds Inst to handle reads from output control points in hull shaders.

Also clean up some random stuff like EmitGetAttribute which is mostly unused for hull/domain other than reading tess coords.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1962 **Author:** [@baggins183](https://github.com/baggins183) **Created:** 12/29/2024 **Status:** ✅ Merged **Merged:** 12/29/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `tess-output-reads` --- ### 📝 Commits (3) - [`7737115`](https://github.com/shadps4-emu/shadPS4/commit/7737115a444f92ba74f9562959abed255ca0ac10) Handle output control point reads in hull shader. Might need additional barriers - [`3e75cc6`](https://github.com/shadps4-emu/shadPS4/commit/3e75cc602dd3abff9bb65c615db28bedf8db5429) output storage class - [`c244a97`](https://github.com/shadps4-emu/shadPS4/commit/c244a973a764b26a8f5c67eef75fca5b31451914) Merge branch 'shadps4-emu:main' into tess-output-reads ### 📊 Changes **7 files changed** (+38 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp` (+7 -8) 📝 `src/shader_recompiler/backend/spirv/emit_spirv_instructions.h` (+2 -0) 📝 `src/shader_recompiler/frontend/translate/vector_memory.cpp` (+0 -4) 📝 `src/shader_recompiler/ir/ir_emitter.cpp` (+6 -0) 📝 `src/shader_recompiler/ir/ir_emitter.h` (+3 -0) 📝 `src/shader_recompiler/ir/opcodes.inc` (+2 -0) 📝 `src/shader_recompiler/ir/passes/hull_shader_transform.cpp` (+18 -10) </details> ### 📄 Description Adds Inst to handle reads from output control points in hull shaders. Also clean up some random stuff like EmitGetAttribute which is mostly unused for hull/domain other than reading tess coords. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>