[PR #1928] [MERGED] build: Fix MoltenVK bundling copy. #2385

New issue

Closed

opened 2026-02-27 21:16:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1928
Author: @squidbus
Created: 12/27/2024
Status: ✅ Merged
Merged: 12/27/2024
Merged by: @georgemoralis

Base: main ← Head: fix-mvk-bundle

📝 Commits (1)

f9a150d build: Fix MoltenVK bundling copy.

📊 Changes

1 file changed (+10 additions, -3 deletions)

View changed files

📝 CMakeLists.txt (+10 -3)

📄 Description

Small fix for MoltenVK bundling, turns out adding as a source and using MACOSX_PACKAGE_LOCATION does not work from a fresh configure so need to use a custom command + target to have a proper dependency chain.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1928 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/27/2024 **Status:** ✅ Merged **Merged:** 12/27/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fix-mvk-bundle` --- ### 📝 Commits (1) - [`f9a150d`](https://github.com/shadps4-emu/shadPS4/commit/f9a150dd0d3e18f9818cfd694e025af8be0ec2dc) build: Fix MoltenVK bundling copy. ### 📊 Changes **1 file changed** (+10 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+10 -3) </details> ### 📄 Description Small fix for MoltenVK bundling, turns out adding as a source and using `MACOSX_PACKAGE_LOCATION` does not work from a fresh configure so need to use a custom command + target to have a proper dependency chain. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>