mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-26 00:05:58 +03:00
[PR #1895] [MERGED] audio: Implement cubeb audio out backend. #2371
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#2371
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/shadps4-emu/shadPS4/pull/1895
Author: @squidbus
Created: 12/26/2024
Status: ✅ Merged
Merged: 12/27/2024
Merged by: @georgemoralis
Base:
main← Head:cubeb📝 Commits (7)
5f4804caudio: Implement cubeb audio out backend.01959bdcubeb_audio: Add some additional safety checks.dc0725acubeb_audio: Add debug logging callback.a7f8aaeaudioout: Refactor backend ports into class.a4ef777pthread: Bump minimum stack size to fix cubeb crash.42fb06dcubeb_audio: Replace output yield loop with condvar.79ed9f2common: Rename ring_buffer_base to RingBuffer.📊 Changes
18 files changed (+731 additions, -88 deletions)
View changed files
📝
.gitmodules(+4 -0)📝
CMakeLists.txt(+6 -3)➕
LICENSES/ISC.txt(+7 -0)📝
externals/CMakeLists.txt(+10 -0)➕
externals/cubeb(+1 -0)📝
src/common/config.cpp(+17 -0)📝
src/common/config.h(+2 -0)➕
src/common/ringbuffer.h(+374 -0)📝
src/core/libraries/audio/audioout.cpp(+28 -31)📝
src/core/libraries/audio/audioout.h(+21 -3)📝
src/core/libraries/audio/audioout_backend.h(+29 -4)➕
src/core/libraries/audio/cubeb_audio.cpp(+158 -0)📝
src/core/libraries/audio/sdl_audio.cpp(+42 -26)➖
src/core/libraries/audio/sdl_audio.h(+0 -18)📝
src/core/libraries/kernel/threads/pthread.cpp(+2 -2)📝
src/emulator.cpp(+1 -1)📝
src/qt_gui/settings_dialog.cpp(+6 -0)📝
src/qt_gui/settings_dialog.ui(+23 -0)📄 Description
Implements a new default audio backend using cubeb, along with a config option to select an audio backend.
This backend does not suffer from https://github.com/shadps4-emu/shadPS4/issues/1717 (at least it fixes it for me), can reduce audio stutter, and implements some extra features like partial support for
sceAudioOutSetVolume.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.