[PR #1889] [MERGED] shader_recompiler: Implement S_BCNT1_I32_B64 and S_FF1_I32_B64 #2368

New issue

Closed

opened 2026-02-27 21:16:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1889
Author: @squidbus
Created: 12/26/2024
Status: ✅ Merged
Merged: 12/27/2024
Merged by: @raphaelthegreat

Base: main ← Head: bcnt1_64

📝 Commits (4)

eeb7325 shader_recompiler: Implement S_BCNT1_I32_B64
34fccbc shader_recompiler: Implement S_FF1_I32_B64
8ee8cd6 shader_recompiler: Implement IEqual for 64-bit.
5c9ae13 shader_recompiler: Fix immediate type in S_FF1_I32_B32

📊 Changes

9 files changed (+68 additions, -12 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/emit_spirv_instructions.h (+4 -1)
📝 src/shader_recompiler/backend/spirv/emit_spirv_integer.cpp (+13 -1)
📝 src/shader_recompiler/frontend/translate/scalar_alu.cpp (+17 -0)
📝 src/shader_recompiler/frontend/translate/translate.h (+2 -0)
📝 src/shader_recompiler/ir/ir_emitter.cpp (+21 -5)
📝 src/shader_recompiler/ir/ir_emitter.h (+2 -2)
📝 src/shader_recompiler/ir/opcodes.inc (+4 -1)
📝 src/shader_recompiler/ir/passes/constant_propagation_pass.cpp (+4 -1)
📝 src/shader_recompiler/ir/passes/resource_tracking_pass.cpp (+1 -1)

📄 Description

Implements S_BCNT1_I32_B64, with a new BitCount64 IR op. Used by Elden Ring.
Implements S_FF1_I32_B64, with a new FindILsb64 and IEqual64 IR ops. Used by DOOM.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1889 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/26/2024 **Status:** ✅ Merged **Merged:** 12/27/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `bcnt1_64` --- ### 📝 Commits (4) - [`eeb7325`](https://github.com/shadps4-emu/shadPS4/commit/eeb732572a1b9df380e68508522a1b4d02392770) shader_recompiler: Implement S_BCNT1_I32_B64 - [`34fccbc`](https://github.com/shadps4-emu/shadPS4/commit/34fccbcc50b0acf291e28adff266537022c6a9bd) shader_recompiler: Implement S_FF1_I32_B64 - [`8ee8cd6`](https://github.com/shadps4-emu/shadPS4/commit/8ee8cd6164b8d00f7dfa9f81108fe431d76eecb0) shader_recompiler: Implement IEqual for 64-bit. - [`5c9ae13`](https://github.com/shadps4-emu/shadPS4/commit/5c9ae130977f74148e50c5609afaeea22c926222) shader_recompiler: Fix immediate type in S_FF1_I32_B32 ### 📊 Changes **9 files changed** (+68 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/emit_spirv_instructions.h` (+4 -1) 📝 `src/shader_recompiler/backend/spirv/emit_spirv_integer.cpp` (+13 -1) 📝 `src/shader_recompiler/frontend/translate/scalar_alu.cpp` (+17 -0) 📝 `src/shader_recompiler/frontend/translate/translate.h` (+2 -0) 📝 `src/shader_recompiler/ir/ir_emitter.cpp` (+21 -5) 📝 `src/shader_recompiler/ir/ir_emitter.h` (+2 -2) 📝 `src/shader_recompiler/ir/opcodes.inc` (+4 -1) 📝 `src/shader_recompiler/ir/passes/constant_propagation_pass.cpp` (+4 -1) 📝 `src/shader_recompiler/ir/passes/resource_tracking_pass.cpp` (+1 -1) </details> ### 📄 Description * Implements `S_BCNT1_I32_B64`, with a new `BitCount64` IR op. Used by Elden Ring. * Implements `S_FF1_I32_B64`, with a new `FindILsb64` and `IEqual64` IR ops. Used by DOOM. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>