[PR #1892] [MERGED] Avoid to access invalid iterator #2367

New issue

Closed

opened 2026-02-27 21:16:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1892
Author: @mailwl
Created: 12/26/2024
Status: ✅ Merged
Merged: 12/27/2024
Merged by: @raphaelthegreat

Base: main ← Head: end_iter

📝 Commits (1)

ecf456b Avoid to access invalid iterator

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 src/core/memory.cpp (+5 -1)

📄 Description

The game Star Ocean: The Divine Force trying to allocate too many direct memory which leads to access to invalid iterator.
Better crash on assert, than accessing bad iterator

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1892 **Author:** [@mailwl](https://github.com/mailwl) **Created:** 12/26/2024 **Status:** ✅ Merged **Merged:** 12/27/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `end_iter` --- ### 📝 Commits (1) - [`ecf456b`](https://github.com/shadps4-emu/shadPS4/commit/ecf456b5c79a09568be77c67ab0553fa6912c84e) Avoid to access invalid iterator ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/core/memory.cpp` (+5 -1) </details> ### 📄 Description The game Star Ocean: The Divine Force trying to allocate too many direct memory which leads to access to invalid iterator. Better crash on assert, than accessing bad iterator --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>