[PR #1887] [MERGED] vk_platform: Enable MoltenVK debug if crash diagnostics is enabled. #2366

New issue

Closed

opened 2026-02-27 21:16:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1887
Author: @squidbus
Created: 12/26/2024
Status: ✅ Merged
Merged: 12/27/2024
Merged by: @raphaelthegreat

Base: main ← Head: mvk-diag

📝 Commits (2)

2a57773 vk_platform: Enable MoltenVK debug if crash diagnostics is enabled.
7cdec6c build: Make sure MoltenVK gets re-bundled when changed.

📊 Changes

2 files changed (+17 additions, -5 deletions)

View changed files

📝 CMakeLists.txt (+5 -5)
📝 src/video_core/renderer_vulkan/vk_platform.cpp (+12 -0)

📄 Description

MoltenVK has a debug mode which includes enabling more detailed GPU command buffer execution information on device loss. Since it doesn't currently support the crash diagnostic layer, enable this instead to get more crash details.

I also had to add enabling VK_EXT_layer_settings which was missing, as MoltenVK actually checks if it is enabled before reading layer settings.

Also fixed a CMake issue where modifying the MoltenVK sub-module would not re-bundle into the output app unless the main target was modified as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1887 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/26/2024 **Status:** ✅ Merged **Merged:** 12/27/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `mvk-diag` --- ### 📝 Commits (2) - [`2a57773`](https://github.com/shadps4-emu/shadPS4/commit/2a57773c00e95ff1b2405731373465be4220a380) vk_platform: Enable MoltenVK debug if crash diagnostics is enabled. - [`7cdec6c`](https://github.com/shadps4-emu/shadPS4/commit/7cdec6cee5ef7bf1ebd3ab5aa996f071a8da1466) build: Make sure MoltenVK gets re-bundled when changed. ### 📊 Changes **2 files changed** (+17 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+5 -5) 📝 `src/video_core/renderer_vulkan/vk_platform.cpp` (+12 -0) </details> ### 📄 Description MoltenVK has a debug mode which includes enabling more detailed GPU command buffer execution information on device loss. Since it doesn't currently support the crash diagnostic layer, enable this instead to get more crash details. I also had to add enabling `VK_EXT_layer_settings` which was missing, as MoltenVK actually checks if it is enabled before reading layer settings. Also fixed a CMake issue where modifying the MoltenVK sub-module would not re-bundle into the output app unless the main target was modified as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>