[PR #1882] [MERGED] Fix button Changelog #2362

New issue

Closed

opened 2026-02-27 21:16:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1882
Author: @DanielSvoboda
Created: 12/25/2024
Status: ✅ Merged
Merged: 12/25/2024
Merged by: @georgemoralis

Base: main ← Head: patch-1

📝 Commits (1)

3d246cc Fix button changelog

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 src/qt_gui/check_update.cpp (+3 -3)

📄 Description

If you are using pre-release, the view changelog button should not appear.
Should not appear because the WIP will always be more up to date than the release, so if you try to update from WIP to release there should be no changelog

In PR 1465 I had made a correction to compare the 'version' in the release channel instead of the 'hash' of the commit so as not to cause a loop when trying to update between releases, and this ended up impacting this other comparison. Because before it was comparing if it started with the letter 'v' in the release channel, but now both start with 'v'. So now it will compare if they contain the word 'WIP' at the end.
As you can see in the print, it now works correctly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1882 **Author:** [@DanielSvoboda](https://github.com/DanielSvoboda) **Created:** 12/25/2024 **Status:** ✅ Merged **Merged:** 12/25/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`3d246cc`](https://github.com/shadps4-emu/shadPS4/commit/3d246cce21867fab0983995e663b109a94548b00) Fix button changelog ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/check_update.cpp` (+3 -3) </details> ### 📄 Description If you are using pre-release, the view changelog button should not appear. Should not appear because the WIP will always be more up to date than the release, so if you try to update from WIP to release there should be no changelog ![image](https://github.com/user-attachments/assets/1609b8c9-7498-4d2c-9bd7-b9d533145d4f) In [PR 1465](https://github.com/shadps4-emu/shadPS4/pull/1465) I had made a correction to compare the 'version' in the release channel instead of the 'hash' of the commit so as not to cause a loop when trying to update between releases, and this ended up impacting this other comparison. Because before it was comparing if it started with the letter 'v' in the release channel, but now both start with 'v'. So now it will compare if they contain the word 'WIP' at the end. As you can see in the print, it now works correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>