[PR #1834] [MERGED] Disable trophy pop-up with config setting #2335

New issue

Closed

opened 2026-02-27 21:16:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1834
Author: @rainmakerv3
Created: 12/21/2024
Status: ✅ Merged
Merged: 12/22/2024
Merged by: @raphaelthegreat

Base: main ← Head: disable-trophies

📝 Commits (1)

c59f6d9 Disable trophy pop-up with config setting

📊 Changes

6 files changed (+42 additions, -16 deletions)

View changed files

📝 src/common/config.cpp (+12 -0)
📝 src/common/config.h (+2 -0)
📝 src/core/libraries/np_trophy/trophy_ui.cpp (+5 -1)
📝 src/qt_gui/settings_dialog.cpp (+7 -1)
📝 src/qt_gui/settings_dialog.ui (+11 -14)
📝 src/qt_gui/translations/en.ts (+5 -0)

📄 Description

Disables the in-game notification pop-up upon earning a trophy with a config setting. Placed under GUI. Description text currently only for English.

This only prevents the pop-up, the trophy xml will still be written to, so the Trophy Viewer still functions same as before.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1834 **Author:** [@rainmakerv3](https://github.com/rainmakerv3) **Created:** 12/21/2024 **Status:** ✅ Merged **Merged:** 12/22/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `disable-trophies` --- ### 📝 Commits (1) - [`c59f6d9`](https://github.com/shadps4-emu/shadPS4/commit/c59f6d9662b3f049b4a7f3a36853c4c573de52e5) Disable trophy pop-up with config setting ### 📊 Changes **6 files changed** (+42 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/common/config.cpp` (+12 -0) 📝 `src/common/config.h` (+2 -0) 📝 `src/core/libraries/np_trophy/trophy_ui.cpp` (+5 -1) 📝 `src/qt_gui/settings_dialog.cpp` (+7 -1) 📝 `src/qt_gui/settings_dialog.ui` (+11 -14) 📝 `src/qt_gui/translations/en.ts` (+5 -0) </details> ### 📄 Description Disables the in-game notification pop-up upon earning a trophy with a config setting. Placed under GUI. Description text currently only for English. This only prevents the pop-up, the trophy xml will still be written to, so the Trophy Viewer still functions same as before. ![image](https://github.com/user-attachments/assets/bb7d2d11-d159-4a8e-b40b-96517d0c85a7) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>