[PR #1832] [MERGED] Fix splash assert #2333

New issue

Closed

opened 2026-02-27 21:16:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1832
Author: @alvinkim101
Created: 12/20/2024
Status: ✅ Merged
Merged: 12/20/2024
Merged by: @polybiusproxy

Base: main ← Head: fix-splash-assert

📝 Commits (2)

e942daf Fix splash assert
b618b13 Use equality operator to compare with ".png"

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/core/file_format/splash.cpp (+1 -1)

📄 Description

Splash::Open assert currently uses stem() which returns the filename without the extension. Instead, extension() should be used.

Also the comparison should use equality, not inequality.

https://en.cppreference.com/w/cpp/filesystem/path/extension
https://en.cppreference.com/w/cpp/filesystem/path/stem

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1832 **Author:** [@alvinkim101](https://github.com/alvinkim101) **Created:** 12/20/2024 **Status:** ✅ Merged **Merged:** 12/20/2024 **Merged by:** [@polybiusproxy](https://github.com/polybiusproxy) **Base:** `main` ← **Head:** `fix-splash-assert` --- ### 📝 Commits (2) - [`e942daf`](https://github.com/shadps4-emu/shadPS4/commit/e942daf9d8cdced9e872ebdaca6d2a6b6a8562a0) Fix splash assert - [`b618b13`](https://github.com/shadps4-emu/shadPS4/commit/b618b13d222c245e5a57b4d2c16aa5a216e3ab87) Use equality operator to compare with ".png" ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/core/file_format/splash.cpp` (+1 -1) </details> ### 📄 Description Splash::Open assert currently uses stem() which returns the filename without the extension. Instead, extension() should be used. Also the comparison should use equality, not inequality. https://en.cppreference.com/w/cpp/filesystem/path/extension https://en.cppreference.com/w/cpp/filesystem/path/stem --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>