[PR #1819] [MERGED] shader_recompiler: Rework image read/write emit. #2323

New issue

Closed

opened 2026-02-27 21:16:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1819
Author: @squidbus
Created: 12/18/2024
Status: ✅ Merged
Merged: 12/24/2024
Merged by: @raphaelthegreat

Base: main ← Head: image-load-store

📝 Commits (1)

017be53 shader_recompiler: Rework image read/write emit.

📊 Changes

15 files changed (+86 additions, -86 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/emit_spirv_image.cpp (+22 -19)
📝 src/shader_recompiler/backend/spirv/emit_spirv_instructions.h (+3 -4)
📝 src/shader_recompiler/backend/spirv/spirv_emit_context.cpp (+4 -3)
📝 src/shader_recompiler/frontend/translate/vector_memory.cpp (+3 -3)
📝 src/shader_recompiler/info.h (+11 -5)
📝 src/shader_recompiler/ir/ir_emitter.cpp (+4 -9)
📝 src/shader_recompiler/ir/ir_emitter.h (+3 -6)
📝 src/shader_recompiler/ir/opcodes.inc (+2 -3)
📝 src/shader_recompiler/ir/passes/resource_tracking_pass.cpp (+21 -26)
📝 src/shader_recompiler/specialization.h (+4 -1)
📝 src/video_core/renderer_vulkan/vk_compute_pipeline.cpp (+3 -2)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+3 -2)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+1 -1)
📝 src/video_core/texture_cache/image_view.cpp (+1 -1)
📝 src/video_core/texture_cache/texture_cache.h (+1 -1)

📄 Description

Refactor ImageFetch and ImageRead IR together.
Handle cube case and better handle mip case for ImageRead instruction.
- For cube case, need to force storage image to use OpImageRead.
Handle multisampling case for ImageWrite instruction.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1819 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/18/2024 **Status:** ✅ Merged **Merged:** 12/24/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `image-load-store` --- ### 📝 Commits (1) - [`017be53`](https://github.com/shadps4-emu/shadPS4/commit/017be5392d0643ea387a134c4e947c8c13b22d1b) shader_recompiler: Rework image read/write emit. ### 📊 Changes **15 files changed** (+86 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/emit_spirv_image.cpp` (+22 -19) 📝 `src/shader_recompiler/backend/spirv/emit_spirv_instructions.h` (+3 -4) 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.cpp` (+4 -3) 📝 `src/shader_recompiler/frontend/translate/vector_memory.cpp` (+3 -3) 📝 `src/shader_recompiler/info.h` (+11 -5) 📝 `src/shader_recompiler/ir/ir_emitter.cpp` (+4 -9) 📝 `src/shader_recompiler/ir/ir_emitter.h` (+3 -6) 📝 `src/shader_recompiler/ir/opcodes.inc` (+2 -3) 📝 `src/shader_recompiler/ir/passes/resource_tracking_pass.cpp` (+21 -26) 📝 `src/shader_recompiler/specialization.h` (+4 -1) 📝 `src/video_core/renderer_vulkan/vk_compute_pipeline.cpp` (+3 -2) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+3 -2) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+1 -1) 📝 `src/video_core/texture_cache/image_view.cpp` (+1 -1) 📝 `src/video_core/texture_cache/texture_cache.h` (+1 -1) </details> ### 📄 Description * Refactor ImageFetch and ImageRead IR together. * Handle cube case and better handle mip case for ImageRead instruction. * For cube case, need to force storage image to use OpImageRead. * Handle multisampling case for ImageWrite instruction. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>