[PR #1800] [MERGED] spirv_emit_context: Prevent double-add of GS in attributes to interface. #2312

New issue

Closed

opened 2026-02-27 21:16:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1800
Author: @squidbus
Created: 12/15/2024
Status: ✅ Merged
Merged: 12/16/2024
Merged by: @raphaelthegreat

Base: main ← Head: gs_in

📝 Commits (1)

21c6b67 spirv_emit_context: Prevent double-add of GS in attributes to interface.

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/spirv_emit_context.cpp (+1 -2)

📄 Description

DefineInput already adds the variable to interfaces, do not push it into interfaces again after. Duplicate definitions are not allowed since SPIR-V 1.4

Also renamed GS inputs from in_attr{} to gs_in_attr{} to be more clear.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1800 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/15/2024 **Status:** ✅ Merged **Merged:** 12/16/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `gs_in` --- ### 📝 Commits (1) - [`21c6b67`](https://github.com/shadps4-emu/shadPS4/commit/21c6b67b106d059a543a5f68ee0043538bf807c6) spirv_emit_context: Prevent double-add of GS in attributes to interface. ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.cpp` (+1 -2) </details> ### 📄 Description `DefineInput` already adds the variable to `interfaces`, do not push it into `interfaces` again after. Duplicate definitions are not allowed since SPIR-V 1.4 Also renamed GS inputs from `in_attr{}` to `gs_in_attr{}` to be more clear. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>