[PR #1795] [MERGED] renderer_vulkan: Various attachment cleanup and fixes. #2307

New issue

Closed

opened 2026-02-27 21:16:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1795
Author: @squidbus
Created: 12/15/2024
Status: ✅ Merged
Merged: 12/22/2024
Merged by: @raphaelthegreat

Base: main ← Head: attach

📝 Commits (1)

50ebc70 renderer_vulkan: Various attachment cleanup and fixes.

📊 Changes

7 files changed (+123 additions, -88 deletions)

View changed files

📝 src/video_core/amdgpu/liverpool.h (+28 -0)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.h (+0 -4)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+12 -25)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+79 -54)
📝 src/video_core/renderer_vulkan/vk_rasterizer.h (+0 -1)
📝 src/video_core/renderer_vulkan/vk_scheduler.cpp (+2 -2)
📝 src/video_core/texture_cache/image_info.cpp (+2 -2)

📄 Description

Add helper functions for depth/stencil buffer validity and use where these checks would happen.
Move pipeline multisampling calculation to simple helper function and use where needed.
Change out duplicated instances of buffer sample count logic with existing NumSamples() function.
Make depth/stencil attachment formats and bindings more state-consistent.
Do not bother attaching color buffers when mode is Disable, since none will be used.
Handle resolve pass with single-sampled source by just doing a copy, as single-sample source resolve is not allowed in Vulkan.
Skip scissor indices that do not have corresponding viewports.
Misc typo fixes and dead code removal.

Fixes some validation errors in games like CUSA05637.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1795 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/15/2024 **Status:** ✅ Merged **Merged:** 12/22/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `attach` --- ### 📝 Commits (1) - [`50ebc70`](https://github.com/shadps4-emu/shadPS4/commit/50ebc70c8099495cf3ad101a7b6c61cb82db2349) renderer_vulkan: Various attachment cleanup and fixes. ### 📊 Changes **7 files changed** (+123 additions, -88 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/amdgpu/liverpool.h` (+28 -0) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.h` (+0 -4) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+12 -25) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+79 -54) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.h` (+0 -1) 📝 `src/video_core/renderer_vulkan/vk_scheduler.cpp` (+2 -2) 📝 `src/video_core/texture_cache/image_info.cpp` (+2 -2) </details> ### 📄 Description * Add helper functions for depth/stencil buffer validity and use where these checks would happen. * Move pipeline multisampling calculation to simple helper function and use where needed. * Change out duplicated instances of buffer sample count logic with existing `NumSamples()` function. * Make depth/stencil attachment formats and bindings more state-consistent. * Do not bother attaching color buffers when mode is `Disable`, since none will be used. * Handle resolve pass with single-sampled source by just doing a copy, as single-sample source resolve is not allowed in Vulkan. * Skip scissor indices that do not have corresponding viewports. * Misc typo fixes and dead code removal. Fixes some validation errors in games like CUSA05637. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>