[PR #1790] [MERGED] resource_tracking_pass: Fix converting dimensions to float for normalization. #2306

Closed
opened 2026-02-27 21:15:59 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1790
Author: @squidbus
Created: 12/14/2024
Status: Merged
Merged: 12/14/2024
Merged by: @raphaelthegreat

Base: mainHead: fix-unnorm


📝 Commits (1)

  • 3641aa7 resource_tracking_pass: Fix converting dimensions to float for normalization.

📊 Changes

1 file changed (+5 additions, -4 deletions)

View changed files

📝 src/shader_recompiler/ir/passes/resource_tracking_pass.cpp (+5 -4)

📄 Description

Meant to do a normal cast here, not bit cast.

Thanks @polybiusproxy for catching this.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1790 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/14/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `fix-unnorm` --- ### 📝 Commits (1) - [`3641aa7`](https://github.com/shadps4-emu/shadPS4/commit/3641aa7a29e89d7abc96679d67a8a5c36d9ec429) resource_tracking_pass: Fix converting dimensions to float for normalization. ### 📊 Changes **1 file changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/ir/passes/resource_tracking_pass.cpp` (+5 -4) </details> ### 📄 Description Meant to do a normal cast here, not bit cast. Thanks @polybiusproxy for catching this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 21:15:59 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2306
No description provided.