[PR #1783] [MERGED] externals: Update sirit to fix debug assert #2300

New issue

Closed

opened 2026-02-27 21:15:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1783
Author: @squidbus
Created: 12/14/2024
Status: ✅ Merged
Merged: 12/14/2024
Merged by: @raphaelthegreat

Base: main ← Head: fix-sirit

📝 Commits (1)

86c7c14 externals: Update sirit to fix debug assert

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 externals/sirit (+1 -1)
📝 src/shader_recompiler/backend/spirv/emit_spirv_image.cpp (+1 -1)

📄 Description

Update sirit to fix debug assert from OpImageWrite
Minor fixup to logging condition to use Sirit::ValidId instead of zero check.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1783 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/14/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `fix-sirit` --- ### 📝 Commits (1) - [`86c7c14`](https://github.com/shadps4-emu/shadPS4/commit/86c7c1402a58e054f35661f2169b491b96b667e1) externals: Update sirit to fix debug assert ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `externals/sirit` (+1 -1) 📝 `src/shader_recompiler/backend/spirv/emit_spirv_image.cpp` (+1 -1) </details> ### 📄 Description * Update sirit to fix debug assert from `OpImageWrite` * Minor fixup to logging condition to use `Sirit::ValidId` instead of zero check. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>