[PR #1776] [MERGED] shader_recompiler: Fixups from stencil changes #2296

Closed
opened 2026-02-27 21:15:56 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1776
Author: @squidbus
Created: 12/14/2024
Status: Merged
Merged: 12/14/2024
Merged by: @raphaelthegreat

Base: mainHead: stencil-fixup


📝 Commits (1)

  • 984be56 shader_recompiler: Fixups from stencil changes

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 src/shader_recompiler/frontend/translate/export.cpp (+1 -1)
📝 src/video_core/texture_cache/image_view.cpp (+2 -1)

📄 Description

  • exp.en == 0 case for depth export is also fine and does not need log message.
  • Some games will try to read stencil as R8Unorm, add to clause for stencil image view for now to avoid crashes but likely needs further work to make the read correct in shader.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1776 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/14/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `stencil-fixup` --- ### 📝 Commits (1) - [`984be56`](https://github.com/shadps4-emu/shadPS4/commit/984be56932b14c9b2d8801b6debb062bd7b5402d) shader_recompiler: Fixups from stencil changes ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/frontend/translate/export.cpp` (+1 -1) 📝 `src/video_core/texture_cache/image_view.cpp` (+2 -1) </details> ### 📄 Description * `exp.en == 0` case for depth export is also fine and does not need log message. * Some games will try to read stencil as `R8Unorm`, add to clause for stencil image view for now to avoid crashes but likely needs further work to make the read correct in shader. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 21:15:56 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2296
No description provided.