[PR #1773] [MERGED] renderer_vulkan: Remove some fallbacks and misc format queries that are no longer needed. #2295

New issue

Closed

opened 2026-02-27 21:15:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1773
Author: @squidbus
Created: 12/14/2024
Status: ✅ Merged
Merged: 12/14/2024
Merged by: @raphaelthegreat

Base: main ← Head: fmt-cleanup

📝 Commits (1)

b9f1737 renderer_vulkan: Remove some fallbacks and misc format queries that are no longer needed.

📊 Changes

3 files changed (+5 additions, -28 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_instance.cpp (+4 -22)
📝 src/video_core/renderer_vulkan/vk_instance.h (+0 -4)
📝 src/video_core/texture_cache/image_view.cpp (+1 -2)

📄 Description

B5G6R5UnormPack16 fallback was added for MoltenVK, but is no longer needed in newer versions we build in as a submodule, so remove the related code. It wasn't complete anyway since it didn't account for situations like storage image, etc.
Remove formats from querying that are no longer used since https://github.com/shadps4-emu/shadPS4/pull/1763

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1773 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/14/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `fmt-cleanup` --- ### 📝 Commits (1) - [`b9f1737`](https://github.com/shadps4-emu/shadPS4/commit/b9f1737d77c4a562d15a35d7d3f587bf3c394df3) renderer_vulkan: Remove some fallbacks and misc format queries that are no longer needed. ### 📊 Changes **3 files changed** (+5 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+4 -22) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+0 -4) 📝 `src/video_core/texture_cache/image_view.cpp` (+1 -2) </details> ### 📄 Description * `B5G6R5UnormPack16` fallback was added for MoltenVK, but is no longer needed in newer versions we build in as a submodule, so remove the related code. It wasn't complete anyway since it didn't account for situations like storage image, etc. * Remove formats from querying that are no longer used since https://github.com/shadps4-emu/shadPS4/pull/1763 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>