[PR #1775] [MERGED] DmaData and Recompiler fixes #2294

New issue

Closed

opened 2026-02-27 21:15:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1775
Author: @roamic
Created: 12/14/2024
Status: ✅ Merged
Merged: 12/14/2024
Merged by: @raphaelthegreat

Base: main ← Head: fix-copy-data

📝 Commits (3)

ec31340 liverpool: fix dmadata packet handling
695b9c8 recompiler: emit a label right after s_branch to prevent dead code interferrence
7e3c452 specialize barriers

📊 Changes

6 files changed (+140 additions, -17 deletions)

View changed files

📝 src/shader_recompiler/frontend/control_flow_graph.cpp (+1 -0)
📝 src/video_core/amdgpu/liverpool.cpp (+13 -13)
📝 src/video_core/buffer_cache/buffer_cache.cpp (+120 -4)
📝 src/video_core/buffer_cache/buffer_cache.h (+1 -0)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+4 -0)
📝 src/video_core/renderer_vulkan/vk_rasterizer.h (+1 -0)

📄 Description

DmaData: handler now prefers copying GPU buffers over CPU. If readback attempt is encountered it will create a GPU buffer still until readback is properly implemented.

Recompiler: fix branch linker for s_branch instructions reading dead code. The issue resulted in s_branch instruction being ignored. We now insert a fake label for all code that follows this instruction so that the block ends on it.

This whole change should fix GS particle effects in bloodborne.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1775 **Author:** [@roamic](https://github.com/roamic) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/14/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `fix-copy-data` --- ### 📝 Commits (3) - [`ec31340`](https://github.com/shadps4-emu/shadPS4/commit/ec31340b1a751f82d0cefe1e8738c67ea66bca45) liverpool: fix dmadata packet handling - [`695b9c8`](https://github.com/shadps4-emu/shadPS4/commit/695b9c86d753394003ffa81719bd96aa2d1c9951) recompiler: emit a label right after s_branch to prevent dead code interferrence - [`7e3c452`](https://github.com/shadps4-emu/shadPS4/commit/7e3c45293359b2060151ca4027539e9e3c0d0b84) specialize barriers ### 📊 Changes **6 files changed** (+140 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/frontend/control_flow_graph.cpp` (+1 -0) 📝 `src/video_core/amdgpu/liverpool.cpp` (+13 -13) 📝 `src/video_core/buffer_cache/buffer_cache.cpp` (+120 -4) 📝 `src/video_core/buffer_cache/buffer_cache.h` (+1 -0) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+4 -0) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.h` (+1 -0) </details> ### 📄 Description `DmaData`: handler now prefers copying GPU buffers over CPU. If readback attempt is encountered it will create a GPU buffer still until readback is properly implemented. Recompiler: fix branch linker for `s_branch` instructions reading dead code. The issue resulted in `s_branch` instruction being ignored. We now insert a fake label for all code that follows this instruction so that the block ends on it. This whole change should fix GS particle effects in bloodborne. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>