mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-25 15:56:00 +03:00
[PR #1767] [MERGED] externals: Add MoltenVK as an external. #2288
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#2288
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/shadps4-emu/shadPS4/pull/1767
Author: @squidbus
Created: 12/14/2024
Status: ✅ Merged
Merged: 12/14/2024
Merged by: @georgemoralis
Base:
main← Head:mvk-build📝 Commits (1)
3c2b222externals: Add MoltenVK as an external.📊 Changes
9 files changed (+119 additions, -28 deletions)
View changed files
📝
.github/workflows/build.yml(+3 -11)📝
.gitmodules(+13 -1)📝
CMakeLists.txt(+1 -2)📝
documents/building-macos.md(+3 -5)📝
externals/CMakeLists.txt(+15 -9)➕
externals/MoltenVK/CMakeLists.txt(+81 -0)➕
externals/MoltenVK/MoltenVK(+1 -0)➕
externals/MoltenVK/SPIRV-Cross(+1 -0)➕
externals/MoltenVK/cereal(+1 -0)📄 Description
Adds MoltenVK as an external built from source. This adds very little to the macOS build time, and provides a few key benefits:
MVK_USE_METAL_PRIVATE_API=1. This gives access to a few extra features that use private Metal APIs, such as sampler mip LOD bias.MoltenVK recently removed the old
VK_NV_glsl_shaderextension and some associated dependencies, which cut down the build complexity and made this more viable.There's already a few nice to haves we get from this ahead of the next release as well:
B5G6R5UnormPack16.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.