[PR #1742] [MERGED] renderer_vulkan: Require exact image format for resolve pass. #2273

New issue

Closed

opened 2026-02-27 21:15:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1742
Author: @squidbus
Created: 12/11/2024
Status: ✅ Merged
Merged: 12/11/2024
Merged by: @psucien

Base: main ← Head: resolve-fmt

📝 Commits (1)

7adf44c renderer_vulkan: Require exact image format for resolve pass.

📊 Changes

3 files changed (+15 additions, -5 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+4 -2)
📝 src/video_core/texture_cache/texture_cache.cpp (+10 -3)
📝 src/video_core/texture_cache/texture_cache.h (+1 -0)

📄 Description

Resolve pass requires the same format for source and destination, both on the AMD GPU and Vulkan sides. Ensure this by requiring the texture cache to return both render target images with the exact requested format.

Part of fixing some multisample resolve issues in Sonic Forces.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1742 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/11/2024 **Status:** ✅ Merged **Merged:** 12/11/2024 **Merged by:** [@psucien](https://github.com/psucien) **Base:** `main` ← **Head:** `resolve-fmt` --- ### 📝 Commits (1) - [`7adf44c`](https://github.com/shadps4-emu/shadPS4/commit/7adf44c89bafea3be6d78c7718104699f871f0ec) renderer_vulkan: Require exact image format for resolve pass. ### 📊 Changes **3 files changed** (+15 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+4 -2) 📝 `src/video_core/texture_cache/texture_cache.cpp` (+10 -3) 📝 `src/video_core/texture_cache/texture_cache.h` (+1 -0) </details> ### 📄 Description Resolve pass requires the same format for source and destination, both on the AMD GPU and Vulkan sides. Ensure this by requiring the texture cache to return both render target images with the exact requested format. Part of fixing some multisample resolve issues in Sonic Forces. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>