[PR #1740] [MERGED] renderer_vulkan: Bind null color attachments when target is masked out. #2271

New issue

Closed

opened 2026-02-27 21:15:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1740
Author: @squidbus
Created: 12/11/2024
Status: ✅ Merged
Merged: 12/11/2024
Merged by: @raphaelthegreat

Base: main ← Head: fix-cb

📝 Commits (2)

6bd3744 renderer_vulkan: Bind null color attachments when target is masked out.
fae6503 Simplify setting null color attachment

📊 Changes

3 files changed (+11 additions, -7 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+3 -2)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+8 -3)
📝 src/video_core/renderer_vulkan/vk_scheduler.h (+0 -2)

📄 Description

Reverts github.com/shadps4-emu/shadPS4@c0d43a1a5f and replaces with binding a null color attachment when the color target is masked out, to make sure the targets are indexed correctly. Also removed some unused state.

Fixes black bars over right and bottom of screen in Sonic Forces.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1740 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/11/2024 **Status:** ✅ Merged **Merged:** 12/11/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `fix-cb` --- ### 📝 Commits (2) - [`6bd3744`](https://github.com/shadps4-emu/shadPS4/commit/6bd3744573fe3064a95a310023e7e2b1fb2ca311) renderer_vulkan: Bind null color attachments when target is masked out. - [`fae6503`](https://github.com/shadps4-emu/shadPS4/commit/fae65036d720d38229e69b2c4d1a077409e20b10) Simplify setting null color attachment ### 📊 Changes **3 files changed** (+11 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+3 -2) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+8 -3) 📝 `src/video_core/renderer_vulkan/vk_scheduler.h` (+0 -2) </details> ### 📄 Description Reverts https://github.com/shadps4-emu/shadPS4/commit/c0d43a1a5f304d21f4b7c9457108c2d21447905e and replaces with binding a null color attachment when the color target is masked out, to make sure the targets are indexed correctly. Also removed some unused state. Fixes black bars over right and bottom of screen in Sonic Forces. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>