[PR #1729] [MERGED] Fix compiling due to typedefs varying across platforms #2265

New issue

Closed

opened 2026-02-27 21:15:49 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1729
Author: @C0rn3j
Created: 12/10/2024
Status: ✅ Merged
Merged: 12/10/2024
Merged by: @raphaelthegreat

Base: main ← Head: C0rn3j-patch-1

📝 Commits (5)

d7c3506 Fix compiling on modern C++ compilers
56b95e4 Fix order
fb65993 Test
ed21163 Test putting flags in old order
7edd6ab Remove designated initializer

📊 Changes

1 file changed (+5 additions, -6 deletions)

View changed files

📝 src/core/thread.cpp (+5 -6)

📄 Description

Fix the var ordering.

https://github.com/shadps4-emu/shadPS4/pull/1724 breaks it and CI does not catch it, as it is using clang ~~a compiler old enough to be complacent~~.

Note that I do not usually do C++ so the fix may be wrong, even though it works for me.

typedef struct
  {
    void *ss_sp;
    int ss_flags;
    size_t ss_size;
  } stack_t;

Fixes error: designator order for field ‘stack_t::ss_flags’ does not match declaration order in ‘const stack_t’

Do squash the extra commit when merging please

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1729 **Author:** [@C0rn3j](https://github.com/C0rn3j) **Created:** 12/10/2024 **Status:** ✅ Merged **Merged:** 12/10/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `C0rn3j-patch-1` --- ### 📝 Commits (5) - [`d7c3506`](https://github.com/shadps4-emu/shadPS4/commit/d7c3506f14359a8e59a069390a7b3b039d101365) Fix compiling on modern C++ compilers - [`56b95e4`](https://github.com/shadps4-emu/shadPS4/commit/56b95e4d19ba9b37843f911e6a47334190e4b97e) Fix order - [`fb65993`](https://github.com/shadps4-emu/shadPS4/commit/fb65993ee4128f583521c1fe59e9ee444b1c8f5e) Test - [`ed21163`](https://github.com/shadps4-emu/shadPS4/commit/ed21163d465a56e4d4fa66b7c84ebea8f966943f) Test putting flags in old order - [`7edd6ab`](https://github.com/shadps4-emu/shadPS4/commit/7edd6ab896e4ffe21ff700c71c256812dc9d64c2) Remove designated initializer ### 📊 Changes **1 file changed** (+5 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/core/thread.cpp` (+5 -6) </details> ### 📄 Description Fix the var ordering. https://github.com/shadps4-emu/shadPS4/pull/1724 breaks it and CI does not catch it, as it is using clang ~~a compiler old enough to be complacent~~. Note that I do not usually do C++ so the fix may be wrong, even though it works for me. ```c++ typedef struct { void *ss_sp; int ss_flags; size_t ss_size; } stack_t; ``` Fixes `error: designator order for field ‘stack_t::ss_flags’ does not match declaration order in ‘const stack_t’` *Do squash the extra commit when merging please* --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>