[PR #1708] [MERGED] image_view: Correct view format for D16Unorm images as well. #2257

Closed
opened 2026-02-27 21:15:47 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1708
Author: @squidbus
Created: 12/8/2024
Status: Merged
Merged: 12/8/2024
Merged by: @psucien

Base: mainHead: fix-d16


📝 Commits (1)

  • af3222c image_view: Correct view format for D16Unorm images as well.

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 src/video_core/texture_cache/image_view.cpp (+3 -2)

📄 Description

Observed Bloodborne using R16Unorm format to view a D16Unorm image for some decals when attacking enemies. Adds this case to the existing format adjustment logic used for R32Sfloat/D32Sfloat to fix validation errors that can also result in crashes.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1708 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/8/2024 **Status:** ✅ Merged **Merged:** 12/8/2024 **Merged by:** [@psucien](https://github.com/psucien) **Base:** `main` ← **Head:** `fix-d16` --- ### 📝 Commits (1) - [`af3222c`](https://github.com/shadps4-emu/shadPS4/commit/af3222cc5dc585057435f0c47328153a5b6913aa) image_view: Correct view format for D16Unorm images as well. ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/texture_cache/image_view.cpp` (+3 -2) </details> ### 📄 Description Observed Bloodborne using `R16Unorm` format to view a `D16Unorm` image for some decals when attacking enemies. Adds this case to the existing format adjustment logic used for `R32Sfloat`/`D32Sfloat` to fix validation errors that can also result in crashes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 21:15:47 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2257
No description provided.