[PR #1676] [MERGED] recompiler: fixed fragment shader built-in attribute access #2241

New issue

Closed

opened 2026-02-27 21:15:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1676
Author: @roamic
Created: 12/6/2024
Status: ✅ Merged
Merged: 12/6/2024
Merged by: @raphaelthegreat

Base: main ← Head: fix-fs-inputs

📝 Commits (3)

ceeca3d recompiler: fixed fragment shader built-in attribute access
dcf6597 handle en/addr separately
81a5062 handle other registers as well

📊 Changes

4 files changed (+101 additions, -9 deletions)

View changed files

📝 src/shader_recompiler/frontend/translate/translate.cpp (+67 -8)
📝 src/shader_recompiler/runtime_info.h (+4 -0)
📝 src/video_core/amdgpu/liverpool.h (+28 -1)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+2 -0)

📄 Description

Registers contain enable flags for built-in attributes that should be checked when recompiling in order to access the correct built-in.

Fixes inverted normals issue in BB that caused some artifacts on grass and mirrored objects (like dog fur).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1676 **Author:** [@roamic](https://github.com/roamic) **Created:** 12/6/2024 **Status:** ✅ Merged **Merged:** 12/6/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `fix-fs-inputs` --- ### 📝 Commits (3) - [`ceeca3d`](https://github.com/shadps4-emu/shadPS4/commit/ceeca3d7181217aafec46e345ecac860197aefb1) recompiler: fixed fragment shader built-in attribute access - [`dcf6597`](https://github.com/shadps4-emu/shadPS4/commit/dcf659735e9927ad2052c9843cb2657703da714d) handle en/addr separately - [`81a5062`](https://github.com/shadps4-emu/shadPS4/commit/81a5062ee95dea6e8075345a9a1f3d9d916a4a5a) handle other registers as well ### 📊 Changes **4 files changed** (+101 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/frontend/translate/translate.cpp` (+67 -8) 📝 `src/shader_recompiler/runtime_info.h` (+4 -0) 📝 `src/video_core/amdgpu/liverpool.h` (+28 -1) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+2 -0) </details> ### 📄 Description Registers contain enable flags for built-in attributes that should be checked when recompiling in order to access the correct built-in. Fixes inverted normals issue in BB that caused some artifacts on grass and mirrored objects (like dog fur). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>