[PR #1653] [CLOSED] shader_recompiler: Read image format info directly from sharps instead of storing in shader info. #2224

New issue

Closed

opened 2026-02-27 21:15:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1653
Author: @squidbus
Created: 12/3/2024
Status: ❌ Closed

Base: main ← Head: shader-info-fmt

📝 Commits (2)

a540ca1 shader_recompiler: Read image format info directly from sharps instead of storing in shader info.
0574d12 shader_recompiler: Fix unbound image fallback.

📊 Changes

11 files changed (+36 additions, -48 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/emit_spirv_image.cpp (+2 -1)
📝 src/shader_recompiler/backend/spirv/spirv_emit_context.cpp (+14 -10)
📝 src/shader_recompiler/frontend/translate/translate.cpp (+0 -1)
📝 src/shader_recompiler/info.h (+4 -4)
📝 src/shader_recompiler/ir/passes/resource_tracking_pass.cpp (+0 -5)
📝 src/shader_recompiler/specialization.h (+1 -2)
📝 src/video_core/amdgpu/resource.h (+10 -15)
📝 src/video_core/buffer_cache/buffer_cache.cpp (+1 -1)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+1 -2)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+1 -2)
📝 src/video_core/texture_cache/image_view.cpp (+2 -5)

📄 Description

Bit of cleanup removing some of the format data stored in Shader::Info structures in favor of always reading it from the sharps.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1653 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/3/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `shader-info-fmt` --- ### 📝 Commits (2) - [`a540ca1`](https://github.com/shadps4-emu/shadPS4/commit/a540ca12cf4c67c93e7ca6ff57a64f1d544b7244) shader_recompiler: Read image format info directly from sharps instead of storing in shader info. - [`0574d12`](https://github.com/shadps4-emu/shadPS4/commit/0574d1274ef47a628c49625fd4c3d5785c1a8030) shader_recompiler: Fix unbound image fallback. ### 📊 Changes **11 files changed** (+36 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/emit_spirv_image.cpp` (+2 -1) 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.cpp` (+14 -10) 📝 `src/shader_recompiler/frontend/translate/translate.cpp` (+0 -1) 📝 `src/shader_recompiler/info.h` (+4 -4) 📝 `src/shader_recompiler/ir/passes/resource_tracking_pass.cpp` (+0 -5) 📝 `src/shader_recompiler/specialization.h` (+1 -2) 📝 `src/video_core/amdgpu/resource.h` (+10 -15) 📝 `src/video_core/buffer_cache/buffer_cache.cpp` (+1 -1) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+1 -2) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+1 -2) 📝 `src/video_core/texture_cache/image_view.cpp` (+2 -5) </details> ### 📄 Description Bit of cleanup removing some of the format data stored in `Shader::Info` structures in favor of always reading it from the sharps. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>