mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-26 00:05:58 +03:00
[PR #1639] [MERGED] playgo: Fix loading PlayGo file. #2219
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#2219
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/shadps4-emu/shadPS4/pull/1639
Author: @squidbus
Created: 12/1/2024
Status: ✅ Merged
Merged: 12/1/2024
Merged by: @raphaelthegreat
Base:
main← Head:fix-playgo📝 Commits (1)
fd2ec5bplaygo: Fix loading PlayGo file.📊 Changes
3 files changed (+30 additions, -31 deletions)
View changed files
📝
src/core/file_format/playgo_chunk.h(+0 -1)📝
src/core/libraries/playgo/playgo.cpp(+30 -23)📝
src/emulator.cpp(+0 -7)📄 Description
Recent cleanup made the PlayGo implementation stop using the
PlayGoFilesingleton, which the file is read to on startup, instead using a new instance that is never read to. This broke games that check PlayGo for file info as they would always receive an error that it was not supported.Adds code to read the file on
scePlayGoInitializeand removes the old singleton read code. Also fixes up how its being checked if PlayGo is initialized.Tested with The Last Guardian.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.