[PR #1631] [MERGED] core: Library cleanup #2209

New issue

Closed

opened 2026-02-27 21:15:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1631
Author: @raphaelthegreat
Created: 11/30/2024
Status: ✅ Merged
Merged: 11/30/2024
Merged by: @raphaelthegreat

Base: main ← Head: spring-clean

📝 Commits (3)

d1c3aeb core: Split error codes into separate files
ba78dc5 core: Bring structs and enums to codebase style
53f3ca0 core: More style changes

📊 Changes

114 files changed (+2159 additions, -2510 deletions)

View changed files

📝 CMakeLists.txt (+31 -19)
➖ src/audio_core/sdl_audio.cpp (+0 -166)
➖ src/audio_core/sdl_audio.h (+0 -39)
📝 src/common/memory_patcher.cpp (+5 -5)
📝 src/core/cpu_patches.h (+2 -0)
📝 src/core/devtools/widget/imgui_memory_editor.h (+1 -1)
📝 src/core/devtools/widget/text_editor.cpp (+1 -1)
📝 src/core/file_format/playgo_chunk.h (+10 -11)
📝 src/core/libraries/app_content/app_content.cpp (+27 -32)
📝 src/core/libraries/app_content/app_content.h (+10 -10)
➕ src/core/libraries/app_content/app_content_error.h (+11 -0)
📝 src/core/libraries/audio/audioout.cpp (+40 -44)
📝 src/core/libraries/audio/audioout.h (+22 -32)
➕ src/core/libraries/audio/audioout_error.h (+34 -0)
➕ src/core/libraries/audio/sdl_audio.cpp (+141 -0)
➕ src/core/libraries/audio/sdl_audio.h (+42 -0)
📝 src/core/libraries/audio3d/audio3d.cpp (+27 -31)
📝 src/core/libraries/audio3d/audio3d.h (+63 -62)
📝 src/core/libraries/audio3d/audio3d_error.h (+2 -0)
📝 src/core/libraries/audio3d/audio3d_impl.h (+1 -1)

...and 80 more files

📄 Description

Nothing to see here (hopefully no regressions), mostly cleans up some low hanging fruit stuff because I was bored

Splits massive error_codes.h header into individual library headers.
Switch to scoped enums when possible with proper style
Switch casing when possible to match codebase
Fix mistake in pngdec color_type enum comparison

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1631 **Author:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Created:** 11/30/2024 **Status:** ✅ Merged **Merged:** 11/30/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `spring-clean` --- ### 📝 Commits (3) - [`d1c3aeb`](https://github.com/shadps4-emu/shadPS4/commit/d1c3aeb8a4aa00df7fcf914e60ab25cb3796129d) core: Split error codes into separate files - [`ba78dc5`](https://github.com/shadps4-emu/shadPS4/commit/ba78dc5552da82468ba8d651c41d43e8eae77b0e) core: Bring structs and enums to codebase style - [`53f3ca0`](https://github.com/shadps4-emu/shadPS4/commit/53f3ca00402ce1b3b9f2a13a75f8f24cca7bde21) core: More style changes ### 📊 Changes **114 files changed** (+2159 additions, -2510 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+31 -19) ➖ `src/audio_core/sdl_audio.cpp` (+0 -166) ➖ `src/audio_core/sdl_audio.h` (+0 -39) 📝 `src/common/memory_patcher.cpp` (+5 -5) 📝 `src/core/cpu_patches.h` (+2 -0) 📝 `src/core/devtools/widget/imgui_memory_editor.h` (+1 -1) 📝 `src/core/devtools/widget/text_editor.cpp` (+1 -1) 📝 `src/core/file_format/playgo_chunk.h` (+10 -11) 📝 `src/core/libraries/app_content/app_content.cpp` (+27 -32) 📝 `src/core/libraries/app_content/app_content.h` (+10 -10) ➕ `src/core/libraries/app_content/app_content_error.h` (+11 -0) 📝 `src/core/libraries/audio/audioout.cpp` (+40 -44) 📝 `src/core/libraries/audio/audioout.h` (+22 -32) ➕ `src/core/libraries/audio/audioout_error.h` (+34 -0) ➕ `src/core/libraries/audio/sdl_audio.cpp` (+141 -0) ➕ `src/core/libraries/audio/sdl_audio.h` (+42 -0) 📝 `src/core/libraries/audio3d/audio3d.cpp` (+27 -31) 📝 `src/core/libraries/audio3d/audio3d.h` (+63 -62) 📝 `src/core/libraries/audio3d/audio3d_error.h` (+2 -0) 📝 `src/core/libraries/audio3d/audio3d_impl.h` (+1 -1) _...and 80 more files_ </details> ### 📄 Description Nothing to see here (hopefully no regressions), mostly cleans up some low hanging fruit stuff because I was bored * Splits massive error_codes.h header into individual library headers. * Switch to scoped enums when possible with proper style * Switch casing when possible to match codebase * Fix mistake in pngdec color_type enum comparison --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>