[PR #1619] [MERGED] Fixed DS_SWIZZLE_32 #2204

Closed
opened 2026-02-27 21:15:35 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1619
Author: @roamic
Created: 11/29/2024
Status: Merged
Merged: 11/29/2024
Merged by: @georgemoralis

Base: mainHead: fix-ds-swizzle-32


📝 Commits (1)

📊 Changes

1 file changed (+2 additions, -3 deletions)

View changed files

📝 src/shader_recompiler/frontend/translate/data_share.cpp (+2 -3)

📄 Description

According to the specs DS_SWIZZLE_32 should not add LaneID to the resulting index. Also it should take the first argument from src[0].
This fixes floor flickering in some locations and walls flickering in another location in that game.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1619 **Author:** [@roamic](https://github.com/roamic) **Created:** 11/29/2024 **Status:** ✅ Merged **Merged:** 11/29/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fix-ds-swizzle-32` --- ### 📝 Commits (1) - [`a275d3c`](https://github.com/shadps4-emu/shadPS4/commit/a275d3cc1df712f7bb32c838c165698e0ac9aef3) Fixed DS_SWIZZLE_32 ### 📊 Changes **1 file changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/frontend/translate/data_share.cpp` (+2 -3) </details> ### 📄 Description According to the specs `DS_SWIZZLE_32` should not add `LaneID` to the resulting index. Also it should take the first argument from `src[0]`. This fixes floor flickering in some locations and walls flickering in another location in _that game_. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 21:15:35 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2204
No description provided.