[PR #1604] [MERGED] [Libs] Ngs2 #2194

New issue

Closed

opened 2026-02-27 21:15:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1604
Author: @lzardy
Created: 11/27/2024
Status: ✅ Merged
Merged: 3/26/2025
Merged by: @georgemoralis

Base: main ← Head: main

📝 Commits (10+)

a53120b [libSceNgs2] Logging & Structs
1962273 clang
1bf1ffa clang
4ba9646 stdarg incl
b90c585 proper logs
356ba6e ngs2 latest
0b21d8a [libSceNgs2] Logging & Structs
0e6df25 clang
6cf9af1 latest
58e26d0 fix includes

📊 Changes

23 files changed (+2103 additions, -267 deletions)

View changed files

📝 CMakeLists.txt (+18 -0)
📝 src/core/libraries/ngs2/ngs2.cpp (+361 -117)
📝 src/core/libraries/ngs2/ngs2.h (+237 -40)
➕ src/core/libraries/ngs2/ngs2_custom.cpp (+12 -0)
➕ src/core/libraries/ngs2/ngs2_custom.h (+444 -0)
➕ src/core/libraries/ngs2/ngs2_eq.cpp (+12 -0)
➕ src/core/libraries/ngs2/ngs2_eq.h (+41 -0)
➕ src/core/libraries/ngs2/ngs2_geom.cpp (+12 -0)
➕ src/core/libraries/ngs2/ngs2_geom.h (+80 -0)
📝 src/core/libraries/ngs2/ngs2_impl.cpp (+114 -96)
📝 src/core/libraries/ngs2/ngs2_impl.h (+167 -14)
➕ src/core/libraries/ngs2/ngs2_mastering.cpp (+12 -0)
➕ src/core/libraries/ngs2/ngs2_mastering.h (+81 -0)
➕ src/core/libraries/ngs2/ngs2_pan.cpp (+12 -0)
➕ src/core/libraries/ngs2/ngs2_pan.h (+25 -0)
➕ src/core/libraries/ngs2/ngs2_report.cpp (+12 -0)
➕ src/core/libraries/ngs2/ngs2_report.h (+78 -0)
➕ src/core/libraries/ngs2/ngs2_reverb.cpp (+12 -0)
➕ src/core/libraries/ngs2/ngs2_reverb.h (+61 -0)
➕ src/core/libraries/ngs2/ngs2_sampler.cpp (+12 -0)

...and 3 more files

📄 Description

Added all ngs2 related headers
Reworked ngs2_impl to be more accurate, including structs (with byte comments, need confirmation)

I can remove the .cpp or .h that are not used or empty if needed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1604 **Author:** [@lzardy](https://github.com/lzardy) **Created:** 11/27/2024 **Status:** ✅ Merged **Merged:** 3/26/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (10+) - [`a53120b`](https://github.com/shadps4-emu/shadPS4/commit/a53120bb1025562fdf88276678c35787fc1c4e46) [libSceNgs2] Logging & Structs - [`1962273`](https://github.com/shadps4-emu/shadPS4/commit/1962273a8f1710f9d4be3819c86958aea2335675) clang - [`1bf1ffa`](https://github.com/shadps4-emu/shadPS4/commit/1bf1ffabd5dcd0ab1bd2830ad70eea686d7cd597) clang - [`4ba9646`](https://github.com/shadps4-emu/shadPS4/commit/4ba964670eaad6508cf23ef763fac8b63fc8e557) stdarg incl - [`b90c585`](https://github.com/shadps4-emu/shadPS4/commit/b90c5858f30e84d80634193c11151b33cbf58d1f) proper logs - [`356ba6e`](https://github.com/shadps4-emu/shadPS4/commit/356ba6e082ace1ef8debe034c129d7280cc9021b) ngs2 latest - [`0b21d8a`](https://github.com/shadps4-emu/shadPS4/commit/0b21d8a00a6647864d036b5a28a30d70880a1a87) [libSceNgs2] Logging & Structs - [`0e6df25`](https://github.com/shadps4-emu/shadPS4/commit/0e6df254b98dc4803129ad652a058d8c7e675bab) clang - [`6cf9af1`](https://github.com/shadps4-emu/shadPS4/commit/6cf9af122d557910349b665f69f3a297945a2d6a) latest - [`58e26d0`](https://github.com/shadps4-emu/shadPS4/commit/58e26d01a72fe4b01e050ea6a5196375ede3c41c) fix includes ### 📊 Changes **23 files changed** (+2103 additions, -267 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+18 -0) 📝 `src/core/libraries/ngs2/ngs2.cpp` (+361 -117) 📝 `src/core/libraries/ngs2/ngs2.h` (+237 -40) ➕ `src/core/libraries/ngs2/ngs2_custom.cpp` (+12 -0) ➕ `src/core/libraries/ngs2/ngs2_custom.h` (+444 -0) ➕ `src/core/libraries/ngs2/ngs2_eq.cpp` (+12 -0) ➕ `src/core/libraries/ngs2/ngs2_eq.h` (+41 -0) ➕ `src/core/libraries/ngs2/ngs2_geom.cpp` (+12 -0) ➕ `src/core/libraries/ngs2/ngs2_geom.h` (+80 -0) 📝 `src/core/libraries/ngs2/ngs2_impl.cpp` (+114 -96) 📝 `src/core/libraries/ngs2/ngs2_impl.h` (+167 -14) ➕ `src/core/libraries/ngs2/ngs2_mastering.cpp` (+12 -0) ➕ `src/core/libraries/ngs2/ngs2_mastering.h` (+81 -0) ➕ `src/core/libraries/ngs2/ngs2_pan.cpp` (+12 -0) ➕ `src/core/libraries/ngs2/ngs2_pan.h` (+25 -0) ➕ `src/core/libraries/ngs2/ngs2_report.cpp` (+12 -0) ➕ `src/core/libraries/ngs2/ngs2_report.h` (+78 -0) ➕ `src/core/libraries/ngs2/ngs2_reverb.cpp` (+12 -0) ➕ `src/core/libraries/ngs2/ngs2_reverb.h` (+61 -0) ➕ `src/core/libraries/ngs2/ngs2_sampler.cpp` (+12 -0) _...and 3 more files_ </details> ### 📄 Description - Added all ngs2 related headers - Reworked `ngs2_impl` to be more accurate, including structs (with byte comments, need confirmation) I can remove the `.cpp` or `.h` that are not used or empty if needed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>